[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-02-01 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349538#comment-16349538
 ] 

Ted Yu commented on HBASE-19895:


Ankit:
Please take a look at the checkstyle warnings w.r.t. TestMajorCompaction.java

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch, HBASE-19895_v1.patch, 
> HBASE-19895_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-02-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349499#comment-16349499
 ] 

Hadoop QA commented on HBASE-19895:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
52s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
53s{color} | {color:red} hbase-server: The patch generated 12 new + 18 
unchanged - 2 fixed = 30 total (was 20) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 1s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m  3s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m 
30s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}132m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19895 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12908869/HBASE-19895_v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 5bd5628b818c 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 38c8144a06 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11341/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11341/testReport/ |
| Max. process+thread count | 5753 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11341/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was 

[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345250#comment-16345250
 ] 

Ted Yu commented on HBASE-19895:


Ankit:
Do you want to roll the fix for HBASE-19896 into this one ?

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch, HBASE-19895_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344815#comment-16344815
 ] 

Hadoop QA commented on HBASE-19895:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
17s{color} | {color:red} root in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
9s{color} | {color:red} hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  1m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in master failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
17s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 17s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} hbase-server: The patch generated 0 new + 0 
unchanged - 20 fixed = 0 total (was 20) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 32 line(s) that end in whitespace. Use 
git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
1s{color} | {color:red} The patch 384 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  0m 
28s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 
2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 16s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue}  0m 
17s{color} | {color:blue} ASF License check generated no output? {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  6m  2s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19895 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12908307/HBASE-19895_v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 613434f88122 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 67f91f1282 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11252/artifact/patchprocess/branch-mvninstall-root.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11252/artifact/patchprocess/branch-compile-hbase-server.txt
 |

[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Ankit Singhal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344797#comment-16344797
 ] 

Ankit Singhal commented on HBASE-19895:
---

{quote}You need to also consider keepDeletedCells here.
{quote}
Thank you , Updated the patch 

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch, HBASE-19895_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344807#comment-16344807
 ] 

Duo Zhang commented on HBASE-19895:
---

+1. Let's see the pre commit result. Seems yetus 0.7.0 is not very stable...

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch, HBASE-19895_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344788#comment-16344788
 ] 

Duo Zhang commented on HBASE-19895:
---

{code}
if (maxVersions == null && ttl == null) {
{code}

You need to also consider keepDeletedCells here.

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344735#comment-16344735
 ] 

Hadoop QA commented on HBASE-19895:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
17s{color} | {color:red} root in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  0m 
34s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in master failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
9s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 17s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
9s{color} | {color:red} hbase-server: The patch generated 30 new + 0 unchanged 
- 0 fixed = 30 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  0m 
17s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 
2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
17s{color} | {color:red} hbase-server in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 17s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue}  0m 
16s{color} | {color:blue} ASF License check generated no output? {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  5m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19895 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12908304/HBASE-19895.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux cc4e5d6822bb 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 67f91f1282 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11250/artifact/patchprocess/branch-mvninstall-root.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11250/artifact/patchprocess/branch-compile-hbase-server.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11250/artifact/patchprocess/branch-javadoc-hbase-server.txt
 |
| mvninstall | 

[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Ankit Singhal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344737#comment-16344737
 ] 

Ankit Singhal commented on HBASE-19895:
---

Thanks [~Apache9] for taking a look.

bq. Is it always safe to do this? We have been trying hard to reduce the 
ability of CP hooks so that CP will not likely to break the logic inside HBase.

I don't find any reference in the code which directly accessing this attribute 
from descriptor(apart from scanInfo) and can cause ambiguity. It just provides 
the flexibility to the user to dynamically override the family attributes for 
the different type of scanners. Do you see any issue?

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344743#comment-16344743
 ] 

Duo Zhang commented on HBASE-19895:
---

Seems fine, just like the TTL and version. You can hook at every place to 
change it to KeepDeletedCells.TRUE, and do filtering by yourself, so the user 
will not see the strange KeepDeletedCells.TRUE in the table description.

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344717#comment-16344717
 ] 

Hadoop QA commented on HBASE-19895:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  2s{color} 
| {color:red} HBASE-19895 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19895 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12908301/HBASE-19895.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11248/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19895) Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks

2018-01-30 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344710#comment-16344710
 ] 

Duo Zhang commented on HBASE-19895:
---

Is it always safe to do this? We have been trying hard to reduce the ability of 
CP hooks so that CP will not likely to break the logic inside HBase.

> Add keepDeletedCells option in ScanOptions for customize scanInfo in pre-hooks
> --
>
> Key: HBASE-19895
> URL: https://issues.apache.org/jira/browse/HBASE-19895
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19895.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)