[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416715#comment-16416715
]
Hudson commented on HBASE-20223:
Results for branch HBASE-19064
[build #77 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch,
> HBASE-20223.002.master.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415521#comment-16415521
]
Hudson commented on HBASE-20223:
Results for branch master
[build #274 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/274/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/274//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/274//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/274//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch,
> HBASE-20223.002.master.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414993#comment-16414993
]
Hudson commented on HBASE-20223:
Results for branch branch-2
[build #534 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/534/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/534//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/534//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/534//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch,
> HBASE-20223.002.master.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414986#comment-16414986
]
Hudson commented on HBASE-20223:
Results for branch branch-2.0
[build #93 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/93/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/93//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/93//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/93//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch,
> HBASE-20223.002.master.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414899#comment-16414899 ] Josh Elser commented on HBASE-20223: Master patch looks good. Will fix the checkstyle on commit. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch, > HBASE-20223.002.master.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414808#comment-16414808
]
Hadoop QA commented on HBASE-20223:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 31 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-checkstyle hbase-spark-it . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s{color} | {color:green} The patch hbase-checkstyle passed checkstyle {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} The patch hbase-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} hbase-server: The patch generated 0 new + 341
unchanged - 1 fixed = 341 total (was 342) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} The patch hbase-thrift passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-backup passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} hbase-it: The patch generated 2 new + 177 unchanged -
2 fixed = 179 total (was 179) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-rest passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-spark-it passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
7s{color} | {color:red} root: The patch generated 2 new + 630 unchanged - 3
fixed = 632 total (was 633) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414611#comment-16414611 ] Sean Busbey commented on HBASE-20223: - rgrgr. I'm working on trying to use shaded-mapreduce now so I have an idea of scope before filing JIRAs for 2.0.0 on the gap. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch, > HBASE-20223.002.master.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414539#comment-16414539 ] Josh Elser commented on HBASE-20223: Pushed branch-2.0 and branch-2. Attaching a patch for master before pushing there. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch, > HBASE-20223.002.master.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412702#comment-16412702 ] Mike Drob commented on HBASE-20223: --- That wasn't clear at all to me. :) Can we make sure that we have ample docs on evangelizing shaded-client and shaded-mapreduce? cc: [~busbey] Meanwhile, +1 on patch. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412671#comment-16412671
]
Josh Elser commented on HBASE-20223:
{quote}So on HBASE-20201 you used the normal hbase-mapreduce jar and not the
shaded one? Trying to understand how we actually end up where we are
{quote}
Correct, I hope this is clear over on HBASE-20201, shout if not. We found this
via "HBase 1.x" ways of submitting mapreduce jobs (fat jar with dependencies or
with libjars and {{$(hbase mapredcp)}}).
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412604#comment-16412604 ] Mike Drob commented on HBASE-20223: --- So on HBASE-20201 you used the normal hbase-mapreduce jar and not the shaded one? Trying to understand how we actually end up where we are > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412143#comment-16412143
]
Josh Elser commented on HBASE-20223:
{quote}Good eye. Definitely at least one thing to remove there. Building those
artifacts and poking at them now.
{quote}
Actually, I take it back. Because our hbase-shaded-client is using Hadoop
artifacts directly (and not the hadoop shaded artifacts), we have to shade
their commons-cli 1.2 and commons-collections 3, even though we use neither
(and have them banned) in our tree. That's fun :)
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412131#comment-16412131
]
Josh Elser commented on HBASE-20223:
{quote}Do we need to update the relocations in {{hbase-shaded/pom.xml}}?
{quote}
Good eye. Definitely at least one thing to remove there. Building those
artifacts and poking at them now.
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412103#comment-16412103
]
Mike Drob commented on HBASE-20223:
---
Do we need to update the relocations in {{hbase-shaded/pom.xml}}?
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412030#comment-16412030 ] stack commented on HBASE-20223: --- Skimmed patch. Looks great. +1 for branch-2.0. Thanks for asking. This is good > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411998#comment-16411998 ] Josh Elser commented on HBASE-20223: [~stack], are you ok with me landing this too? Will fix checkstyles on commit, if so. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch, HBASE-20223.002.branch-2.0.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411912#comment-16411912
]
Hadoop QA commented on HBASE-20223:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 29 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
2s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
41s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
15s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-checkstyle . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
22s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
16s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch hbase-checkstyle passed checkstyle {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} The patch hbase-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-procedure passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} hbase-server: The patch generated 0 new + 343
unchanged - 1 fixed = 343 total (was 344) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} The patch hbase-thrift passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} hbase-it: The patch generated 2 new + 175 unchanged -
2 fixed = 177 total (was 177) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-rest passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
4s{color} | {color:red} root: The patch generated 3 new + 713 unchanged - 4
fixed = 716 total (was 717) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
12s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
37s{color} | {color:green} patch has no errors
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408161#comment-16408161
]
Josh Elser commented on HBASE-20223:
{quote}Not critical, but my patch HBASE-20214 fails with the commons-collection
v4 removed from dependencies. Why was the decision to remove V4 instead of
upgrading to it and removing V3?
{quote}
>From what I could see, we shouldn't have been using the commons-collection3
>API in the first place. This is coming in transitively through Hadoop. Thus, a
>change in what Hadoop does, could unknowingly break HBase (which is bad).
> Use hbase-thirdparty 2.1.0
> --
>
> Key: HBASE-20223
> URL: https://issues.apache.org/jira/browse/HBASE-20223
> Project: HBase
> Issue Type: Task
> Components: dependencies
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-20223.001.patch
>
>
> Update hbase to account for the changes to hbase-thirdparty:
> * new (internal) protobuf version
> * shaded commons-cli
> * shaded commons-collections4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407710#comment-16407710 ] BELUGA BEHR commented on HBASE-20223: - Not critical, but my patch [HBASE-20214] fails with the commons-collection v4 removed from dependencies. Why was the decision to remove V4 instead of upgrading to it and removing V3? CC: [~appy] > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20223) Use hbase-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/HBASE-20223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405281#comment-16405281 ] Josh Elser commented on HBASE-20223: .001 has the changes necessary for 3rdparty 2.1.0, but avoiding "submit patch" as this release isn't yet published. > Use hbase-thirdparty 2.1.0 > -- > > Key: HBASE-20223 > URL: https://issues.apache.org/jira/browse/HBASE-20223 > Project: HBase > Issue Type: Task > Components: dependencies >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20223.001.patch > > > Update hbase to account for the changes to hbase-thirdparty: > * new (internal) protobuf version > * shaded commons-cli > * shaded commons-collections4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
