[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729981#comment-16729981
]
Andrey Elenskiy commented on HBASE-21545:
-
Thanks for reviewing and merging!
I've created
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728470#comment-16728470
]
stack commented on HBASE-21545:
---
[~jatsakthi] Attached is what I see as a screenshot sir.
>
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728374#comment-16728374
]
Hudson commented on HBASE-21545:
Results for branch branch-2.1
[build #709 on
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728380#comment-16728380
]
Hudson commented on HBASE-21545:
Results for branch branch-2
[build #1575 on
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728347#comment-16728347
]
Hudson commented on HBASE-21545:
Results for branch master
[build #679 on
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728338#comment-16728338
]
Hudson commented on HBASE-21545:
Results for branch branch-2.0
[build #1192 on
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728212#comment-16728212
]
Sakthi commented on HBASE-21545:
[~stack], I had updated my profile few days back(with email). It shows
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728161#comment-16728161
]
stack commented on HBASE-21545:
---
[~jatsakthi] Fix you profile in JIRA. Add an email. I wanted to add you
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728088#comment-16728088
]
Duo Zhang commented on HBASE-21545:
---
+1, let's try. And please fix the checkstyle issues before
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728062#comment-16728062
]
Hadoop QA commented on HBASE-21545:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728035#comment-16728035
]
stack commented on HBASE-21545:
---
Link to Phil Yang's original work adding 'new version handling'
>
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728040#comment-16728040
]
Sakthi commented on HBASE-21545:
Thanks [~stack] for taking a look.
> NEW_VERSION_BEHAVIOR breaks
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728034#comment-16728034
]
stack commented on HBASE-21545:
---
Thanks for the work here [~timoha](and [~jatsakthi]). Patch looks great
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727181#comment-16727181
]
Andrey Elenskiy commented on HBASE-21545:
-
Create new request on reviewboard:
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726543#comment-16726543
]
Sakthi commented on HBASE-21545:
[~timoha], I think we can try to get this in as the added UT works and
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720589#comment-16720589
]
Sakthi commented on HBASE-21545:
Yes, I think we need to open new jiras. The new version of the failing
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719532#comment-16719532
]
Andrey Elenskiy commented on HBASE-21545:
-
The assertion in checkVersions() seems to be another
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719510#comment-16719510
]
Andrey Elenskiy commented on HBASE-21545:
-
Started debugging with TestKeepDeletes:
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719330#comment-16719330
]
Andrey Elenskiy commented on HBASE-21545:
-
I also have those failing on my machine.
So the tests
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718726#comment-16718726
]
Sakthi commented on HBASE-21545:
Also, please move the Jira to 'In progress' mode.
>
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718720#comment-16718720
]
Sakthi commented on HBASE-21545:
[~timoha], I ran all UTs with
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717870#comment-16717870
]
Andrey Elenskiy commented on HBASE-21545:
-
[~jatsakthi] looks like I uploaded wrong patch for 4,
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712524#comment-16712524
]
Sakthi commented on HBASE-21545:
I tried applying your patch, [~timoha]. Did you make any changes in
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710686#comment-16710686
]
Andrey Elenskiy commented on HBASE-21545:
-
I've uploaded a patch where I modified
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709497#comment-16709497
]
Andrey Elenskiy commented on HBASE-21545:
-
Ok, I've attached patch with the fix and a unit test
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709411#comment-16709411
]
Andrey Elenskiy commented on HBASE-21545:
-
Got curious to learn and dig through the code. I
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709405#comment-16709405
]
Sakthi commented on HBASE-21545:
Yes, you are right [~timoha]. I tried converting TestPutWithDelete too,
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709353#comment-16709353
]
Andrey Elenskiy commented on HBASE-21545:
-
Oh, I'm not planning on working on a fix as I don't
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709340#comment-16709340
]
Sakthi commented on HBASE-21545:
Perfect, thanks [~timoha]
> NEW_VERSION_BEHAVIOR breaks Get/Scan with
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709338#comment-16709338
]
Andrey Elenskiy commented on HBASE-21545:
-
ignore the first patch, the second patch has a test
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709324#comment-16709324
]
Sakthi commented on HBASE-21545:
Was able to repro the issue. Will come up with a test case soon.
>
[
https://issues.apache.org/jira/browse/HBASE-21545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708814#comment-16708814
]
Sean Busbey commented on HBASE-21545:
-
Hi [~timoha]! thanks for writing this up. Could you provide
32 matches
Mail list logo
