[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274418#comment-13274418
]
Devaraj Das commented on HBASE-5732:
bq. Recent trunk build failure was caused by an
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273665#comment-13273665
]
stack commented on HBASE-5732:
--
Committed to trunk. Thanks for the patch DD. Thanks for
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273671#comment-13273671
]
Devaraj Das commented on HBASE-5732:
Thanks, Stack, Andrew and Ted.. I'll take care of
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273698#comment-13273698
]
Hudson commented on HBASE-5732:
---
Integrated in HBase-TRUNK #2865 (See
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273844#comment-13273844
]
Hudson commented on HBASE-5732:
---
Integrated in HBase-TRUNK #2870 (See
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272885#comment-13272885
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272947#comment-13272947
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272960#comment-13272960
]
Devaraj Das commented on HBASE-5732:
There are actually no unit test failures (when i
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272975#comment-13272975
]
Zhihong Yu commented on HBASE-5732:
---
Reattaching patch v12 would allow Hadoop QA to
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272995#comment-13272995
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273036#comment-13273036
]
Zhihong Yu commented on HBASE-5732:
---
Patch v12 is ready for integration.
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271642#comment-13271642
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271919#comment-13271919
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271957#comment-13271957
]
Zhihong Yu commented on HBASE-5732:
---
For this change:
{code}
-
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271966#comment-13271966
]
Devaraj Das commented on HBASE-5732:
Good points, Ted. Maybe we should punt on these
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271970#comment-13271970
]
Zhihong Yu commented on HBASE-5732:
---
@Devaraj:
I think punting this particular change to
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272030#comment-13272030
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272048#comment-13272048
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272050#comment-13272050
]
Zhihong Yu commented on HBASE-5732:
---
In most recent PreCommit run:
{code}
Running
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272051#comment-13272051
]
Zhihong Yu commented on HBASE-5732:
---
@Devaraj:
I found the following JIRAs related to
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270295#comment-13270295
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270296#comment-13270296
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270306#comment-13270306
]
Devaraj Das commented on HBASE-5732:
I think the patch is close now. I haven't tested
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270565#comment-13270565
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270597#comment-13270597
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270718#comment-13270718
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270722#comment-13270722
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270724#comment-13270724
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270791#comment-13270791
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270793#comment-13270793
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270796#comment-13270796
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270829#comment-13270829
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270850#comment-13270850
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270865#comment-13270865
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270915#comment-13270915
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270936#comment-13270936
]
Zhihong Yu commented on HBASE-5732:
---
I looped TestMXBean 4 times with patch v9 and they
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268394#comment-13268394
]
Devaraj Das commented on HBASE-5732:
Yeah I should have commented back on RB.. Sorry
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267270#comment-13267270
]
Devaraj Das commented on HBASE-5732:
bq. There is no corresponding remove of the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267933#comment-13267933
]
stack commented on HBASE-5732:
--
DD, you can comment over in rb too -- that'd be better
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266994#comment-13266994
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266042#comment-13266042
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266222#comment-13266222
]
jirapos...@reviews.apache.org commented on HBASE-5732:
--
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266228#comment-13266228
]
Zhihong Yu commented on HBASE-5732:
---
Latest patch runs security unit tests in default
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266247#comment-13266247
]
Devaraj Das commented on HBASE-5732:
bq. Latest patch runs security unit tests in
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266256#comment-13266256
]
stack commented on HBASE-5732:
--
@Deveraj We ship with 3.4.x but do not require that you run a
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266260#comment-13266260
]
Devaraj Das commented on HBASE-5732:
No this patch doesn't change anything to do with
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266326#comment-13266326
]
Hadoop QA commented on HBASE-5732:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261325#comment-13261325
]
Andrew Purtell commented on HBASE-5732:
---
Only the secure RPC basics have been
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261738#comment-13261738
]
Zhihong Yu commented on HBASE-5732:
---
Since AccessController and TokenProvider
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261853#comment-13261853
]
Devaraj Das commented on HBASE-5732:
In the last patch, I missed adding the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260280#comment-13260280
]
stack commented on HBASE-5732:
--
@Devaraj If this patch only works against 1.0.x hadoop, what
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260488#comment-13260488
]
Andrew Purtell commented on HBASE-5732:
---
The only thing in security/ after the RPC
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260780#comment-13260780
]
Devaraj Das commented on HBASE-5732:
bq. HBase Cyclic Replication Issue: some data are
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260782#comment-13260782
]
Devaraj Das commented on HBASE-5732:
Sorry my copy-paste buffer was stale (it could
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261312#comment-13261312
]
Andrew Purtell commented on HBASE-5732:
---
TokenProvider is an interesting issue. On
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261318#comment-13261318
]
Zhihong Yu commented on HBASE-5732:
---
Now that security profile is gone in patch v2, the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258819#comment-13258819
]
Andrew Purtell commented on HBASE-5732:
---
bq. I'll revert User.java and have it only
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258626#comment-13258626
]
Devaraj Das commented on HBASE-5732:
bq. On review board, it is obvious where white
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258628#comment-13258628
]
Devaraj Das commented on HBASE-5732:
I forgot to mention that I'll keep the User shim
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258632#comment-13258632
]
Zhihong Yu commented on HBASE-5732:
---
Start with https://reviews.apache.org/r/new/:
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258634#comment-13258634
]
Devaraj Das commented on HBASE-5732:
Ah I thought you had uploaded the patch on
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258637#comment-13258637
]
Zhihong Yu commented on HBASE-5732:
---
Only the review requester can update the patch for
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257053#comment-13257053
]
Zhihong Yu commented on HBASE-5732:
---
We haven't put zookeeper 3.4.x as requirement for
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255345#comment-13255345
]
Andrew Purtell commented on HBASE-5732:
---
The reason the User abstraction exists is
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255360#comment-13255360
]
Devaraj Das commented on HBASE-5732:
Thanks, Zhihong for the detailed comments. I'll
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255398#comment-13255398
]
Andrew Purtell commented on HBASE-5732:
---
bq. Andrew, this patch hasn't been tested
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255765#comment-13255765
]
Devaraj Das commented on HBASE-5732:
bq. I'm all for removing shims and hacks wherever
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255767#comment-13255767
]
Devaraj Das commented on HBASE-5732:
bq. over in Hadoop, there is a discussion around
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255267#comment-13255267
]
Zhihong Yu commented on HBASE-5732:
---
I got some compilation errors:
{code}
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255281#comment-13255281
]
Zhihong Yu commented on HBASE-5732:
---
I put the patch on review board, below are comments
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255282#comment-13255282
]
Devaraj Das commented on HBASE-5732:
Thanks, Zhihong for the review. I forgot to
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255285#comment-13255285
]
Zhihong Yu commented on HBASE-5732:
---
Thanks for the hint about compilation, Devaraj.
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255320#comment-13255320
]
Zhihong Yu commented on HBASE-5732:
---
On review board, it is obvious where white spaces
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247681#comment-13247681
]
stack commented on HBASE-5732:
--
Sounds good. You on this DD?
Remove the
[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247700#comment-13247700
]
Devaraj Das commented on HBASE-5732:
I will take a stab at this.
75 matches
Mail list logo