[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259589#comment-13259589
 ] 

Hadoop QA commented on HBASE-5850:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.util.TestProcessBasedCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1606//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1606//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1606//console

This message is automatically generated.

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, 
 backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, 
 backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-23 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260103#comment-13260103
 ] 

Lars Hofhansl commented on HBASE-5850:
--

The patches look good to me. Anybody opposed if I committed them to all 
branches?

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.0

 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, 
 backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, 
 backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-23 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260119#comment-13260119
 ] 

Lars Hofhansl commented on HBASE-5850:
--

Or phrased differently:
+1 on patches. Anybody else +1?

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.0

 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, 
 backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, 
 backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-23 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260138#comment-13260138
 ] 

stack commented on HBASE-5850:
--

+1

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.0

 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, 
 backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, 
 backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread xufeng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259008#comment-13259008
 ] 

xufeng commented on HBASE-5850:
---

@Lars
I think we should add checkInitialized() to HMaster#createTable() in trunk and 
0.94.
So I created the patch for trunk and 0.94.

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2

 Attachments: backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259321#comment-13259321
 ] 

Zhihong Yu commented on HBASE-5850:
---

@Xufeng:
Can you attach test suite result for 0.90 ?

Thanks

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259322#comment-13259322
 ] 

Hadoop QA commented on HBASE-5850:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523622/backport-5454-to-90.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1601//console

This message is automatically generated.

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259343#comment-13259343
 ] 

Hadoop QA commented on HBASE-5850:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1602//console

This message is automatically generated.

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread xufeng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259345#comment-13259345
 ] 

xufeng commented on HBASE-5850:
---

@Ted

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread xufeng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259346#comment-13259346
 ] 

xufeng commented on HBASE-5850:
---

@Ted
I get the 90 version at revision 1329041 from  
http://svn.apache.org/repos/asf/hbase/branches/0.90.
But this error also exist.
${noformat}
---
 T E S T S
---
Running org.apache.hadoop.hbase.master.TestMasterFailover
killed.
${noformat}

Does this error also exist in your test env?

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized

2012-04-22 Thread Zhihong Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259347#comment-13259347
 ] 

Zhihong Yu commented on HBASE-5850:
---

Stack provided a patch to fix this test in HBASE-5833
Can you try his patch ?

Thanks

 Backport HBASE-5454 to 90 and 92  Refuse operations from Admin before master 
 is initialized
 ---

 Key: HBASE-5850
 URL: https://issues.apache.org/jira/browse/HBASE-5850
 Project: HBase
  Issue Type: Bug
Reporter: xufeng
Assignee: xufeng
 Fix For: 0.90.7, 0.92.2, 0.94.1

 Attachments: 5850-trunk.txt, backport-5454(createTable)-to-94.patch, 
 backport-5454(createTable)-to-94_surefire-report.html, 
 backport-5454(createTable)-to-trunk.patch, 
 backport-5454(createTable)-to-trunk_surefire-report.html, 
 backport-5454-to-90.patch, backport-5454-to-92.patch, 
 backport-5454-to-92_surefire-report.html


 This issue is needed in 0.90 0.92 also.
 And update the hbase-5454 patch that add the checkInitialized() into 
 HMaster#createTable().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira