[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265009#comment-13265009
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
Let me update the resolved
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263684#comment-13263684
]
Jonathan Hsieh commented on HBASE-5864:
---
I haven't looked carefully but do you all
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262400#comment-13262400
]
Lars Hofhansl commented on HBASE-5864:
--
@Ram: You are right it is a small change.
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262401#comment-13262401
]
Lars Hofhansl commented on HBASE-5864:
--
Ah OK. Never mind, you need the Block to the
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262403#comment-13262403
]
Lars Hofhansl commented on HBASE-5864:
--
I think I get the change now. +1
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262812#comment-13262812
]
Lars Hofhansl commented on HBASE-5864:
--
Going to commit in a few unless there're
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263100#comment-13263100
]
Hudson commented on HBASE-5864:
---
Integrated in HBase-0.94 #151 (See
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263136#comment-13263136
]
Hudson commented on HBASE-5864:
---
Integrated in HBase-0.94-security #22 (See
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263185#comment-13263185
]
Hudson commented on HBASE-5864:
---
Integrated in HBase-TRUNK #2819 (See
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263373#comment-13263373
]
Hudson commented on HBASE-5864:
---
Integrated in HBase-TRUNK-security #186 (See
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261654#comment-13261654
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
Updated the patch. All
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261686#comment-13261686
]
Hadoop QA commented on HBASE-5864:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261831#comment-13261831
]
dhruba borthakur commented on HBASE-5864:
-
Thanks for finding this ramkrishna. I
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261917#comment-13261917
]
Lars Hofhansl commented on HBASE-5864:
--
TestRegionRebalancing is unrelated
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262266#comment-13262266
]
Zhihong Yu commented on HBASE-5864:
---
Latest patch looks good. Minor comments:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262363#comment-13262363
]
Lars Hofhansl commented on HBASE-5864:
--
This is the only issue in the way of the next
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262383#comment-13262383
]
dhruba borthakur commented on HBASE-5864:
-
The meat of the change is in
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262385#comment-13262385
]
dhruba borthakur commented on HBASE-5864:
-
I also grepped thru the code to see if
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262389#comment-13262389
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
@Dhruba
Thanks for looking
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262391#comment-13262391
]
Lars Hofhansl commented on HBASE-5864:
--
bq. The meat of the change is in
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262393#comment-13262393
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
@Lars
I still feel the
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260456#comment-13260456
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
Please correct me if am
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260455#comment-13260455
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
The problem is because of
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260634#comment-13260634
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
I have attached a sample
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260645#comment-13260645
]
stack commented on HBASE-5864:
--
Good find lads. I'm not sure I follow. Is it fixable?
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260665#comment-13260665
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
The attached patch seems to
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260672#comment-13260672
]
stack commented on HBASE-5864:
--
I'm not sure I follow what your patch is doing Ram. And
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260697#comment-13260697
]
Zhihong Yu commented on HBASE-5864:
---
{code}
-DataInputStream
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260700#comment-13260700
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
Just added a test case to
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260703#comment-13260703
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
@Ted
Sorry just now saw
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260709#comment-13260709
]
Zhihong Yu commented on HBASE-5864:
---
Patch v2 passes the new test.
{code}
+ private
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260743#comment-13260743
]
Zhihong Yu commented on HBASE-5864:
---
The following computation assumes checksum is on:
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260744#comment-13260744
]
Hadoop QA commented on HBASE-5864:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261183#comment-13261183
]
Lars Hofhansl commented on HBASE-5864:
--
Dhruba should have a look this too.
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261276#comment-13261276
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
bq.Dhruba should have a
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261307#comment-13261307
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
bq.I suggest using
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261315#comment-13261315
]
Lars Hofhansl commented on HBASE-5864:
--
I also don't quite follow the patch or
[
https://issues.apache.org/jira/browse/HBASE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261319#comment-13261319
]
ramkrishna.s.vasudevan commented on HBASE-5864:
---
@Lars
In a file that has
38 matches
Mail list logo