[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407623#comment-13407623 ] Lars Hofhansl commented on HBASE-6253: -- +1 on patch. Let's tackle online schema change in a separate issue (against 0.94.2). Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407647#comment-13407647 ] Andrew Purtell commented on HBASE-6253: --- I have these changes queued for commit to trunk and 0.94 branch. Will commit after local tests pass. Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400294#comment-13400294 ] Laxman commented on HBASE-6253: --- should we consider disallowing all DDL operations (add/delete/modify column)? with online schema change, its not mandatory that we need to diable the table. that means, we can drop the columns of acl table even now. Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400296#comment-13400296 ] Laxman commented on HBASE-6253: --- by DDL i consider : AddColumn, ModifyColumn, DeleteColumn, EnableTable, DisableTable, ModifyTable, DeleteTable Reference: ACL matrix available @ HBASE-6192 Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400297#comment-13400297 ] ramkrishna.s.vasudevan commented on HBASE-6253: --- I think its better we fix keeping online schema changes also. Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400317#comment-13400317 ] Hadoop QA commented on HBASE-6253: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533259/HBASE-6253.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2247//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2247//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2247//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2247//console This message is automatically generated. Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6253) Dont allow user to disable/drop _acl_ table
[ https://issues.apache.org/jira/browse/HBASE-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400665#comment-13400665 ] Andrew Purtell commented on HBASE-6253: --- +1 on patch Dont allow user to disable/drop _acl_ table --- Key: HBASE-6253 URL: https://issues.apache.org/jira/browse/HBASE-6253 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.94.0, 0.96.0, 0.94.1 Reporter: Gopinathan A Labels: security Fix For: 0.94.1 Attachments: HBASE-6253.patch, HBASE-6253.patch Currently HTableDescriptor.isLegalTableName API doesn't check for the _acl_ table name, due to this user can able to disable/enable/drop/create the acl table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira