[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575600#comment-13575600 ] Francis Liu commented on HBASE-7043: [~te...@apache.org] I believe it'll automatically do some testing for commands that are part of the shell. Though I don't see this actually being run as part of any of the maven phases? Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch, HBASE-7043_94_3.patch, HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575603#comment-13575603
]
Hadoop QA commented on HBASE-7043:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12568783/HBASE-7043_94_4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4408//console
This message is automatically generated.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch,
HBASE-7043_94_3.patch, HBASE-7043_94_4.patch, HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571206#comment-13571206
]
Hadoop QA commented on HBASE-7043:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12567986/HBASE-7043_94_3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4330//console
This message is automatically generated.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch,
HBASE-7043_94_3.patch, HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571571#comment-13571571 ] Ted Yu commented on HBASE-7043: --- There're new Ruby scripts in the patch. Would they be tested by running TestShell ? Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch, HBASE-7043_94_3.patch, HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571581#comment-13571581
]
Ted Yu commented on HBASE-7043:
---
For group_admin.rb :
{code}
+# Wrapper for org.apache.hadoop.hbase.client.HBaseAdmin
{code}
The script is for managing groups. Please add more comment.
For group_add.rb :
{code}
+Add a new group.
{code}
Please be more specific: region server group is added.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch,
HBASE-7043_94_3.patch, HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490509#comment-13490509
]
Hadoop QA commented on HBASE-7043:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552074/HBASE-7043_94_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3225//console
This message is automatically generated.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94_2.patch, HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490518#comment-13490518
]
Hadoop QA commented on HBASE-7043:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552075/HBASE-6721_94_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3227//console
This message is automatically generated.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch,
HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491018#comment-13491018 ] Sergey Shelukhin commented on HBASE-7043: - Which is the correct v2 patch? 7043 or 6721? Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-6721_94_2.patch, HBASE-7043_94_2.patch, HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487572#comment-13487572 ] Francis Liu commented on HBASE-7043: What keeps it from getting into 0.94? Is it the new method in HMaster? Since we're only adding a method that should keep things binary compatible to older versions at least. Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488080#comment-13488080 ] Andrew Purtell commented on HBASE-7043: --- bq. What keeps it from getting into 0.94? The current attached patch makes a ton of changes in o.a.h.h.master. This stuff should all be pulled out into a separate package that can be put into a Maven module like done with security in 0.94. What changes to core code remain after that? Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486186#comment-13486186 ] Sergey Shelukhin commented on HBASE-7043: - Backporting seems harmless to me, although this is a new feature, and I'm not sure where the 0.94 bar is currently. [~stack] can existing CONFIG stuff be backported to 0.94? Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486284#comment-13486284 ] Andrew Purtell commented on HBASE-7043: --- It's unlikely that HBASE-6721 would go in to 0.94. Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484302#comment-13484302
]
Sergey Shelukhin commented on HBASE-7043:
-
{noformat}
else (k =~ /rs_group/i)
# validate coprocessor specs
v = String.new(value)
v.strip!
htd.setValue(k, value)
{noformat}
1) Comment is invalid.
2) Similar functionality is in trunk already; see CONFIG. Or is it intended for
something else?
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484312#comment-13484312
]
Sergey Shelukhin commented on HBASE-7043:
-
It may be because my Ruby-fu is weak, but this doesn't look right:
{noformat}
res[entry.getKey] ||= {}
res[entry.getKey] = entry.getVal
{noformat}
Also, res is set in this and many similar places and not used.
Nit: footer count output is inconsistent (e.g. getGroup doesn't output it)
Nit #2: group_move_server should be called ...serverS imho, and description
updated accordingly.
Also the patch is for 0.94 but fixed version says 0.96. Is is this for 0.94?
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484342#comment-13484342
]
Francis Liu commented on HBASE-7043:
{quote}
1) Comment is invalid.
2) Similar functionality is in trunk already; see CONFIG. Or is it intended for
something else?
{quote}
Good catch, can we backport this functionality?
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484351#comment-13484351
]
Francis Liu commented on HBASE-7043:
{quote}
Also the patch is for 0.94 but fixed version says 0.96. Is is this for 0.94?
{quote}
Yep, we will be creating an 0.96 patch. 0.94 is the version we currently plan
on using this feature with thus hoping it can be backported.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483056#comment-13483056 ] Francis Liu commented on HBASE-7043: 0.94 initial patch for review Region Server Group CLI commands Key: HBASE-7043 URL: https://issues.apache.org/jira/browse/HBASE-7043 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Francis Liu Fix For: 0.96.0 Attachments: HBASE-7043_94.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7043) Region Server Group CLI commands
[
https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483063#comment-13483063
]
Hadoop QA commented on HBASE-7043:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550600/HBASE-7043_94.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3135//console
This message is automatically generated.
Region Server Group CLI commands
Key: HBASE-7043
URL: https://issues.apache.org/jira/browse/HBASE-7043
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Fix For: 0.96.0
Attachments: HBASE-7043_94.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
