[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[
https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708874#comment-13708874
]
Benoit Sigoure commented on HBASE-8952:
---
I attached a patch that fixes the issue for me in 0.95 – the patch would need
to be ported to other branches as well as to the secure RPC implementation,
which is separate in 0.94 ({{ipc/SecureServer.java}}).
Missing error handling can cause RegionServer RPC thread to busy loop forever
-
Key: HBASE-8952
URL: https://issues.apache.org/jira/browse/HBASE-8952
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Reporter: Benoit Sigoure
Assignee: Benoit Sigoure
Attachments: HBASE-8952.patch
This bug seems to be present in all released versions of HBase, including the
tip of the 0.94 and 0.95 branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[
https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708977#comment-13708977
]
Hadoop QA commented on HBASE-8952:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12592386/HBASE-8952.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6346//console
This message is automatically generated.
Missing error handling can cause RegionServer RPC thread to busy loop forever
-
Key: HBASE-8952
URL: https://issues.apache.org/jira/browse/HBASE-8952
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Reporter: Benoit Sigoure
Assignee: Benoit Sigoure
Attachments: HBASE-8952.patch
If the connection to the client is closed unexpectedly and at the wrong
time, the code will attempt to keep reading from the socket in a busy loop.
This bug seems to be present in all released versions of HBase, including the
tip of the 0.94 and 0.95 branches, however I only ran into it while porting
AsyncHBase to 0.95
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[
https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709018#comment-13709018
]
Hadoop QA commented on HBASE-8952:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12592408/8952.094.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6349//console
This message is automatically generated.
Missing error handling can cause RegionServer RPC thread to busy loop forever
-
Key: HBASE-8952
URL: https://issues.apache.org/jira/browse/HBASE-8952
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Reporter: Benoit Sigoure
Assignee: Benoit Sigoure
Fix For: 0.98.0, 0.95.2, 0.94.10
Attachments: 8952.094.txt, HBASE-8952.patch
If the connection to the client is closed unexpectedly and at the wrong
time, the code will attempt to keep reading from the socket in a busy loop.
This bug seems to be present in all released versions of HBase, including the
tip of the 0.94 and 0.95 branches, however I only ran into it while porting
AsyncHBase to 0.95
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709112#comment-13709112 ] Lars Hofhansl commented on HBASE-8952: -- Yes, but the 0.94 patch looks like a no op. Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2, 0.94.10 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709122#comment-13709122 ] stack commented on HBASE-8952: -- hmm... will commit returning the count. Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2, 0.94.10 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709130#comment-13709130 ] stack commented on HBASE-8952: -- Forget it. 0.94 doesn't need this patch. Thanks [~lhofhansl] Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2, 0.94.10 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709230#comment-13709230 ] Hudson commented on HBASE-8952: --- SUCCESS: Integrated in HBase-TRUNK #4256 (See [https://builds.apache.org/job/HBase-TRUNK/4256/]) HBASE-8952 Missing error handling can cause RegionServer RPC thread to busy loop forever (stack: rev 1503475) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709245#comment-13709245 ] Hudson commented on HBASE-8952: --- FAILURE: Integrated in hbase-0.95 #327 (See [https://builds.apache.org/job/hbase-0.95/327/]) HBASE-8952 Missing error handling can cause RegionServer RPC thread to busy loop forever (stack: rev 1503473) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709264#comment-13709264 ] Hudson commented on HBASE-8952: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #617 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/617/]) HBASE-8952 Missing error handling can cause RegionServer RPC thread to busy loop forever (stack: rev 1503475) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8952) Missing error handling can cause RegionServer RPC thread to busy loop forever
[ https://issues.apache.org/jira/browse/HBASE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709284#comment-13709284 ] Hudson commented on HBASE-8952: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #180 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/180/]) HBASE-8952 Missing error handling can cause RegionServer RPC thread to busy loop forever (stack: rev 1503473) * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java Missing error handling can cause RegionServer RPC thread to busy loop forever - Key: HBASE-8952 URL: https://issues.apache.org/jira/browse/HBASE-8952 Project: HBase Issue Type: Bug Components: IPC/RPC Reporter: Benoit Sigoure Assignee: Benoit Sigoure Fix For: 0.98.0, 0.95.2 Attachments: 8952.094.txt, HBASE-8952.patch If the connection to the client is closed unexpectedly and at the wrong time, the code will attempt to keep reading from the socket in a busy loop. This bug seems to be present in all released versions of HBase, including the tip of the 0.94 and 0.95 branches, however I only ran into it while porting AsyncHBase to 0.95 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
