[jira] [Updated] (HBASE-4793) HBase shell still using deprecated methods removed in HBASE-4436

[Ted Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4793:
--

Priority: Critical  (was: Blocker)

Lowering priority before we find the next broken shell command.

 HBase shell still using deprecated methods removed in HBASE-4436
 

 Key: HBASE-4793
 URL: https://issues.apache.org/jira/browse/HBASE-4793
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 0.92.0, 0.94.0
Reporter: Gary Helmling
Priority: Critical
 Fix For: 0.92.0

 Attachments: 4793.txt


 The patch applied in HBASE-4622 (subtask of HBASE-4436) to remove deprecated 
 methods seems to have missed some usage of those methods by the HBase shell.  
 At least src/main/ruby/hbase/admin.rb is still using some of the removed 
 methods, breaking some shell commands:
 {noformat}
 hbase(main):007:0 alter 'privatetable', { NAME = 'f1', VERSIONS = 2}
 ERROR: wrong number of arguments (3 for 2)
 Backtrace: /usr/lib/hbase/bin/../bin/../lib/ruby/hbase/admin.rb:344:in `alter'
org/jruby/RubyArray.java:1572:in `each'
/usr/lib/hbase/bin/../bin/../lib/ruby/hbase/admin.rb:317:in `alter'

 /usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands/alter.rb:79:in `command'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:68:in 
 `format_simple_command'

 /usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands/alter.rb:78:in `command'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:31:in 
 `command_safe'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:74:in 
 `translate_hbase_exceptions'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:31:in 
 `command_safe'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell.rb:110:in `command'
(eval):2:in `alter'
 {noformat}
 This trace translates to the line:
 {code}
   @admin.modifyColumn(table_name, column_name, descriptor)
 {code}
 which is calling one of the removed methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4793) HBase shell still using deprecated methods removed in HBASE-4436

[Ted Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4793:
--

Attachment: 4793.txt

Patch fixes parameters for admin.modifyColumn()

There could be other places to be fixed.

 HBase shell still using deprecated methods removed in HBASE-4436
 

 Key: HBASE-4793
 URL: https://issues.apache.org/jira/browse/HBASE-4793
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 0.92.0, 0.94.0
Reporter: Gary Helmling
Priority: Blocker
 Fix For: 0.92.0

 Attachments: 4793.txt


 The patch applied in HBASE-4622 (subtask of HBASE-4436) to remove deprecated 
 methods seems to have missed some usage of those methods by the HBase shell.  
 At least src/main/ruby/hbase/admin.rb is still using some of the removed 
 methods, breaking some shell commands:
 {noformat}
 hbase(main):007:0 alter 'privatetable', { NAME = 'f1', VERSIONS = 2}
 ERROR: wrong number of arguments (3 for 2)
 Backtrace: /usr/lib/hbase/bin/../bin/../lib/ruby/hbase/admin.rb:344:in `alter'
org/jruby/RubyArray.java:1572:in `each'
/usr/lib/hbase/bin/../bin/../lib/ruby/hbase/admin.rb:317:in `alter'

 /usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands/alter.rb:79:in `command'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:68:in 
 `format_simple_command'

 /usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands/alter.rb:78:in `command'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:31:in 
 `command_safe'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:74:in 
 `translate_hbase_exceptions'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell/commands.rb:31:in 
 `command_safe'
/usr/lib/hbase/bin/../bin/../lib/ruby/shell.rb:110:in `command'
(eval):2:in `alter'
 {noformat}
 This trace translates to the line:
 {code}
   @admin.modifyColumn(table_name, column_name, descriptor)
 {code}
 which is calling one of the removed methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira