[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-11 Thread Uma Maheswara Rao G (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HBASE-5645:
---

Attachment: HBASE-5645-3.patch

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, 
 HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-11 Thread Jonathan Hsieh (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5645:
--

   Resolution: Fixed
Fix Version/s: 0.96.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Lgtm.  Thanks David and thanks Uma and Stack for taking a look.  I've committed 
to trunk.

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Fix For: 0.96.0

 Attachments: HBASE-5645-2.patch, HBASE-5645-3.patch, 
 HBASE-5645.patch, HBASE-5645.patch, hbase-5645-2-tweak.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Status: Open  (was: Patch Available)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Attachment: HBASE-5645-2.patch

Updated to latest trunk; fixed test hang.  Passed -PrunAllTests and 
test-patch.sh.  Will attach to reviewboard once this passes the robot.

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Status: Patch Available  (was: Open)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Status: In Progress  (was: Patch Available)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Status: Patch Available  (was: In Progress)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Jonathan Hsieh (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5645:
--

Comment: was deleted

(was: lgtm. 

I just checked in HBASE_5653 that reduced the find bugs number, which likely 
breaks this patch.  I'm going to submit patch to find out the new number and 
the tweak v2 to reflect this new number.)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Jonathan Hsieh (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5645:
--

Attachment: hbase-5645-2-tweak.patch

Attached a tweaked version that excludes an HLog change already included by 
HBASE-5653 and removed count update so we can get new count.

Letting bot run to get new findbugs count.

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch, 
 hbase-5645-2-tweak.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-05 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5645:
-

Attachment: HBASE-5645.patch

retry

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch, HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5645:
-

Status: Open  (was: Patch Available)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5645:
-

Status: Patch Available  (was: Open)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5645:
-

Attachment: HBASE-5645.patch

Resubmit of same patch

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch, HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-03 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Attachment: HBASE-5645.patch

Run this through the bot.

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-03 Thread David S. Wang (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David S. Wang updated HBASE-5645:
-

Status: Patch Available  (was: Open)

 [findbugs] Fix correctness warnings
 ---

 Key: HBASE-5645
 URL: https://issues.apache.org/jira/browse/HBASE-5645
 Project: HBase
  Issue Type: Sub-task
  Components: scripts
Reporter: Jonathan Hsieh
Assignee: David S. Wang
 Attachments: HBASE-5645.patch


 See 
 https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
 Fix the warnings in the correctness section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira