[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257273#comment-13257273 ] Hudson commented on HBASE-3585: --- Integrated in HBase-TRUNK-security #175 (See [https://builds.apache.org/job/HBase-TRUNK-security/175/]) HBASE-3585 isLegalFamilyName() can throw ArrayOutOfBoundException (Revision 1327666) Result = FAILURE stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1, 0.96.0 Reporter: Prakash Khemani Assignee: Uma Maheswara Rao G Priority: Minor Fix For: 0.96.0 Attachments: HBASE-3585.patch org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256997#comment-13256997 ] Hudson commented on HBASE-3585: --- Integrated in HBase-TRUNK #2783 (See [https://builds.apache.org/job/HBase-TRUNK/2783/]) HBASE-3585 isLegalFamilyName() can throw ArrayOutOfBoundException (Revision 1327666) Result = FAILURE stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1, 0.96.0 Reporter: Prakash Khemani Assignee: Uma Maheswara Rao G Priority: Minor Fix For: 0.96.0 Attachments: HBASE-3585.patch org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255820#comment-13255820 ] Hadoop QA commented on HBASE-3585: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522987/HBASE-3585.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1552//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1552//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1552//console This message is automatically generated. isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Assignee: Uma Maheswara Rao G Priority: Minor Attachments: HBASE-3585.patch org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255873#comment-13255873 ] Uma Maheswara Rao G commented on HBASE-3585: Test failure and findbugs are unrelated to this change. isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Assignee: Uma Maheswara Rao G Priority: Minor Attachments: HBASE-3585.patch org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[
https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254596#comment-13254596
]
Uma Maheswara Rao G commented on HBASE-3585:
Currently in trunk, isLegalFamilyName used in below constructor and that is
deprecated constructor.
{code}
@Deprecated
public HColumnDescriptor(final byte[] familyName, final int minVersions,
final int maxVersions, final boolean keepDeletedCells,
final String compression, final boolean encodeOnDisk,
final String dataBlockEncoding, final boolean inMemory,
final boolean blockCacheEnabled, final int blocksize,
final int timeToLive, final String bloomFilter, final int scope) {
isLegalFamilyName(familyName);
{code}
And the usable constructor is making use of this deprecated constructors
internally. Also validated for familyName length in this usable constructor
already.
{code}
public HColumnDescriptor(final byte [] familyName) {
this (familyName == null || familyName.length = 0?
HConstants.EMPTY_BYTE_ARRAY: familyName, DEFAULT_VERSIONS,
DEFAULT_COMPRESSION, DEFAULT_IN_MEMORY, DEFAULT_BLOCKCACHE,
DEFAULT_TTL, DEFAULT_BLOOMFILTER);
}
{code}
But isLegalFamilyName is marked as public and used only in HColumnDescriptor
class.
Anyway ths simple fix couldbe to move down that validation to last constructor,
where we are finally populating the values with setter metods.
{code}
public HColumnDescriptor(final byte[] familyName, final int minVersions,
final int maxVersions, final boolean keepDeletedCells,
final String compression, final boolean encodeOnDisk,
final String dataBlockEncoding, final boolean inMemory,
final boolean blockCacheEnabled, final int blocksize,
final int timeToLive, final String bloomFilter, final int scope) {
{code}
isLegalFamilyName() can throw ArrayOutOfBoundException
--
Key: HBASE-3585
URL: https://issues.apache.org/jira/browse/HBASE-3585
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.1
Reporter: Prakash Khemani
Priority: Minor
org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses
byte[0] w/o first checking the array length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255325#comment-13255325 ] stack commented on HBASE-3585: -- Have a patch Uma? isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Priority: Minor org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255328#comment-13255328 ] Uma Maheswara Rao G commented on HBASE-3585: @Stack, I will post the patch in some time today. isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Assignee: Uma Maheswara Rao G Priority: Minor org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001629#comment-13001629 ] stack commented on HBASE-3585: -- @Prakash What did you enter to generate the issue? Thanks. isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Priority: Minor org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001696#comment-13001696 ] ryan rawson commented on HBASE-3585: interesting catch, can you provide a test and patch that fixes it? we should probably throw a better exception I think huh? isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Priority: Minor org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3585) isLegalFamilyName() can throw ArrayOutOfBoundException
[ https://issues.apache.org/jira/browse/HBASE-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001884#comment-13001884 ] Prakash Khemani commented on HBASE-3585: The ArrayOutOfBound exception happened when doing admin.create(htd) where the HTableDescriptor htd had zero length family-name. isLegalFamilyName() can throw ArrayOutOfBoundException -- Key: HBASE-3585 URL: https://issues.apache.org/jira/browse/HBASE-3585 Project: HBase Issue Type: Bug Components: client Affects Versions: 0.90.1 Reporter: Prakash Khemani Priority: Minor org.apache.hadoop.hbase.HColumnDescriptor.isLegalFamilyName(byte[]) accesses byte[0] w/o first checking the array length. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
