[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-17 Thread via GitHub
2005hithlj commented on code in PR #4966: URL: https://github.com/apache/hbase/pull/4966#discussion_r1100914426 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSyncUp.java: ## @@ -69,41 +80,103 @@ public static void main(String[] args)

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-02-08 Thread via GitHub
2005hithlj commented on code in PR #4966: URL: https://github.com/apache/hbase/pull/4966#discussion_r1100077789 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSyncUp.java: ## @@ -116,14 +189,20 @@ public boolean isAborted() {

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-02-08 Thread via GitHub
2005hithlj commented on code in PR #4966: URL: https://github.com/apache/hbase/pull/4966#discussion_r1100073675 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSyncUp.java: ## @@ -69,41 +80,103 @@ public static void main(String[] args)

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-02-08 Thread via GitHub
2005hithlj commented on code in PR #4966: URL: https://github.com/apache/hbase/pull/4966#discussion_r1100069154 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/AssignReplicationQueuesProcedure.java: ## @@ -130,18 +133,51 @@ private Flow