[GitHub] [hbase] 2005hithlj commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false

2022-05-22 Thread GitBox
2005hithlj commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-1134057573 I successfully ran the failed UTs in our Jenkins environment. The failed UTs includes 3TestReplicationEndpointWithMultipleWAL, TestReplicationEndpoint, TestNamedQueueRecorder,

[GitHub] [hbase] 2005hithlj commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false

2022-05-06 Thread GitBox
2005hithlj commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-1120084218 Have re-triggered the pre-commit check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] 2005hithlj commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false

2022-05-05 Thread GitBox
2005hithlj commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-1118448036 > The test failure is tracked by [HBASE-26998](https://issues.apache.org/jira/browse/HBASE-26998) and PR #4404 , please rebase and push the commit after #4404 is merged @2005hithlj .

[GitHub] [hbase] 2005hithlj commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false

2022-04-27 Thread GitBox
2005hithlj commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-676287 Some UTs failed, let me analyze the reasons... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] 2005hithlj commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false

2022-04-27 Thread GitBox
2005hithlj commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-015425 Please help me review it, thanks. @carp84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go