[GitHub] [hbase] Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level
Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/586#issuecomment-528480890 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 6m 42s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 3m 16s | branch-1 passed | | :green_heart: | compile | 1m 6s | branch-1 passed | | :green_heart: | checkstyle | 2m 0s | branch-1 passed | | :broken_heart: | shadedjars | 0m 12s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 59s | branch-1 passed | | :blue_heart: | spotbugs | 2m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 3m 0s | branch-1 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 11s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 1m 47s | the patch passed | | :green_heart: | compile | 1m 7s | the patch passed | | :green_heart: | javac | 1m 7s | the patch passed | | :green_heart: | checkstyle | 1m 57s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 12s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 32s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 58s | the patch passed | | :green_heart: | findbugs | 3m 14s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 24s | hbase-hadoop-compat in the patch passed. | | :green_heart: | unit | 0m 30s | hbase-hadoop2-compat in the patch passed. | | :green_heart: | unit | 109m 47s | hbase-server in the patch passed. | | :broken_heart: | asflicense | 1m 13s | The patch generated 2 ASF License warnings. | | | | 147m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/586 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d1d8c05d7ccc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh | | git revision | branch-1 / 352344c | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/branch-shadedjars.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/patch-shadedjars.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 4314 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level
Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/586#issuecomment-528401886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 5m 55s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 3m 15s | branch-1 passed | | :green_heart: | compile | 1m 5s | branch-1 passed | | :green_heart: | checkstyle | 2m 2s | branch-1 passed | | :broken_heart: | shadedjars | 0m 13s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 0s | branch-1 passed | | :blue_heart: | spotbugs | 2m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 3m 0s | branch-1 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 11s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 1m 47s | the patch passed | | :green_heart: | compile | 1m 6s | the patch passed | | :green_heart: | javac | 1m 6s | the patch passed | | :broken_heart: | checkstyle | 0m 12s | hbase-hadoop2-compat: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 11s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 36s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 56s | the patch passed | | :broken_heart: | findbugs | 0m 36s | hbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 0m 25s | hbase-hadoop-compat in the patch passed. | | :green_heart: | unit | 0m 30s | hbase-hadoop2-compat in the patch passed. | | :green_heart: | unit | 110m 24s | hbase-server in the patch passed. | | :broken_heart: | asflicense | 1m 13s | The patch generated 2 ASF License warnings. | | | | 147m 33s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-hadoop2-compat | | | Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:[line 60] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/586 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4b4d25d74244 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh | | git revision | branch-1 / 352344c | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/new-findbugs-hbase-hadoop2-compat.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/patch-asflicense-problems.txt
[GitHub] [hbase] Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level
Apache-HBase commented on issue #586: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/586#issuecomment-528335410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 44s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 5m 53s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 3m 22s | branch-1 passed | | :green_heart: | compile | 1m 11s | branch-1 passed | | :green_heart: | checkstyle | 2m 8s | branch-1 passed | | :broken_heart: | shadedjars | 0m 13s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 59s | branch-1 passed | | :blue_heart: | spotbugs | 2m 8s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 3m 9s | branch-1 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 11s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 1m 54s | the patch passed | | :green_heart: | compile | 1m 9s | the patch passed | | :green_heart: | javac | 1m 9s | the patch passed | | :broken_heart: | checkstyle | 0m 11s | hbase-hadoop-compat: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | :broken_heart: | checkstyle | 0m 13s | hbase-hadoop2-compat: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 12s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 58s | the patch passed | | :broken_heart: | findbugs | 0m 36s | hbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 0m 23s | hbase-hadoop-compat in the patch passed. | | :green_heart: | unit | 0m 31s | hbase-hadoop2-compat in the patch passed. | | :broken_heart: | unit | 116m 45s | hbase-server in the patch failed. | | :broken_heart: | asflicense | 1m 3s | The patch generated 2 ASF License warnings. | | | | 155m 7s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-hadoop2-compat | | | Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:[line 60] | | Failed junit tests | hadoop.hbase.regionserver.TestCompactionWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/586 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e0a56bcbf623 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh | | git revision | branch-1 / 157ffae | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/patch-shadedjars.txt | |
