[GitHub] [hbase] Apache9 commented on a change in pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-25 Thread GitBox
Apache9 commented on a change in pull request #2669: URL: https://github.com/apache/hbase/pull/2669#discussion_r530805655 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java ## @@ -128,32 +129,17 @@ public static void

[GitHub] [hbase] Apache9 commented on a change in pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-18 Thread GitBox
Apache9 commented on a change in pull request #2669: URL: https://github.com/apache/hbase/pull/2669#discussion_r526512744 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java ## @@ -390,8 +391,8 @@ private void onCallFinished(Call call,

[GitHub] [hbase] Apache9 commented on a change in pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-18 Thread GitBox
Apache9 commented on a change in pull request #2669: URL: https://github.com/apache/hbase/pull/2669#discussion_r526510319 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -186,6 +183,33 @@ private void

[GitHub] [hbase] Apache9 commented on a change in pull request #2669: HBASE-25292 Improve InetSocketAddress usage discipline

2020-11-17 Thread GitBox
Apache9 commented on a change in pull request #2669: URL: https://github.com/apache/hbase/pull/2669#discussion_r525646192 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java ## @@ -135,10 +136,10 @@ private int