[GitHub] [hbase] WenFeiYi commented on a change in pull request #2148: HBASE-24752 NPE/500 accessing webui on master startup

[GitBox]

WenFeiYi commented on a change in pull request #2148:
URL: https://github.com/apache/hbase/pull/2148#discussion_r461292991



##########
File path: 
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
##########
@@ -224,6 +225,11 @@ AssignmentManager assignmentManager = 
master.getAssignmentManager();
           <& AssignmentManagerStatusTmpl; 
assignmentManager=master.getAssignmentManager()&>
         </%if>
         <%if !master.isInMaintenanceMode() %>
+          <%java>
+          while (master.getMasterCoprocessorHost() == null) {
+            Threads.sleep(50);

Review comment:
       my negligence, there are some similar problems and solutions in front

##########
File path: 
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
##########
@@ -223,7 +223,7 @@ AssignmentManager assignmentManager = 
master.getAssignmentManager();
         <%if master.getAssignmentManager() != null %>
           <& AssignmentManagerStatusTmpl; 
assignmentManager=master.getAssignmentManager()&>
         </%if>
-        <%if !master.isInMaintenanceMode() %>
+        <%if !master.isInMaintenanceMode() &&  
master.getMasterCoprocessorHost() != null %>

Review comment:
       thanks for reminding




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org