[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-25 Thread GitBox
apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733967159 Let me make another pass to fix up checkstyle and insure VisibleForTesting is really gone. In one precommit it seems to have come back somewhere.

[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733404029 Rebased. Pushed checkstyle fixes. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] apurtell commented on pull request #2697: HBASE-24640 [branch-1] Purge use of VisibleForTesting

2020-11-24 Thread GitBox
apurtell commented on pull request #2697: URL: https://github.com/apache/hbase/pull/2697#issuecomment-733096844 @Reidd Will rebase. I can also make a pass over these checkstyle warns. Was expecting some legacy issues to turn up.