apurtell opened a new pull request #3302: URL: https://github.com/apache/hbase/pull/3302
We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge. It's common for contributors to be unaware of this practice and reviewers might not catch it. On another subtask I will introduce a build enforcer that bans System.currentTimeMillis() except where we annotate to allow it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
