[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554781113 Please node that I changed a couple of NPE to be IllegalStateException (Guava Preconditions#checkState) as these are more appropriate excepti

[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554768282 @saintstack Hey, sorry, didn't see that you reviewed this code already so I tried to put in a force-push to keep things cleaner. Ended up me