[GitHub] [hbase] bharathv commented on pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…
bharathv commented on pull request #3332: URL: https://github.com/apache/hbase/pull/3332#issuecomment-851151731 > FSHLog also been closed in async way in Master branch. Pls see FSHLog#doReplaceWriter. No applicable there? @anoopsjohn Thanks for pointing it out, I incorrectly assumed that FSHLog behavior stayed the same in branch-2/master. This async closing of FSHLog was not ported to branch-1. On top of that branch-2/master tests have coverage only for AsyncWAL since that is the default and that didn't help. The latest patch fixes this issue for both the implementations along with test coverage. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…
bharathv commented on pull request #3332: URL: https://github.com/apache/hbase/pull/3332#issuecomment-850759150 Test failures are not related, looped them over 100 times and they passed locally (failed-to-read.. is a known issue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #3332: HBASE-25932: Ensure replication reads trailer bytes with AsyncWAL imp…
bharathv commented on pull request #3332: URL: https://github.com/apache/hbase/pull/3332#issuecomment-850602486 @shahrs87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
