brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-529073634
> https://blogs.apache.org/roller-ui/menu.rol is how you log on to the
blog. I think you have to be added. It might be a PMC chair thing... checking.
Otherwise, open
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-529046219
Thank you for approving this PR, guys. I will commit it. Thanks!
> Suggest you cast the README as a blog post for hbase.apache.org. The
README is complete and
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-528176572
It looks like the QA is okay.
@saintstack Could you please take a look at this? As Josh, Sean and Andrew
have approved it, If you are okay with it, I will commit
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-527533978
> the easiest way is to squash your commits and force push to your feature
branch.
I did do this.
> Left a new comment (throw
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-527383162
Applying the patch in the QA is failing for some reason, GitHub is still
showing "This branch has no conflicts with the base branch" though. Checking.
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-527160286
I think I have done for all the review comments. Could you please review
them? @saintstack @joshelser @busbey @apurtell
Thanks!
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-527133071
@joshelser
Regarding the issue where the byte-sizes don't get rolled up to the next
unit, I added a logic to do it. Can you please review it?
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-526935451
> if you think it'll be easier to maintain this if it lives in the main repo
and you're likely to be doing follow on work, then I think we're better off
just keeping it
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-525581706
On the Stack's first concern (that we should use a 3rd party terminal/libs
instead of writing our own), I think we should use a terminal lib to avoid
reinventing the
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-525573187
@apurtell I fixed the bug in the following commit:
https://github.com/apache/hbase/pull/476/commits/8808de68fb6123dc6d0d034d3b16a0d5b45ba3f6
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-525201984
@joshelser
> One question I haven't been able to find the answer to on my own yet: when
do byte-sizes get rolled up to the next unit? (e.g. MB to GB)
>
>
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-524495695
I found some bug of the Terminal implementation and fixed them in the new
commit I added.
This is an
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-523071494
Thank you for your comment. @saintstack
> 1. We are adding this to hbase itself rather than to hbase-operator-tools;
would be good if it could live outside of
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-522586164
Could you please review this PR when you get a chance? @saintstack @Apache9
@apurtell @joshelser @busbey
I have added README
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-520925801
I added README
(https://github.com/brfrn169/hbase/blob/HBASE-11062/hbase-hbtop/README.md) in
the hbtop module so that reviewers can see the details of hbtop.
brfrn169 commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-520276091
Thank you for reviewing! @saintstack
> Put some images up in the JIRA so we can see how it looks.
Sure, will update the Jira.
> How did you come up
16 matches
Mail list logo
