brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-734067225
I don't think the failed UTs are related to this change. The failed UTs were
successful locally. I will merge this PR.
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-734006919
I don't think the failed UTs in the last QA are related to this patch, but I
will trigger QA again just in case.
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-733819400
Seems the failed UTs for TestAsyncTable are not related to this patch.
But it looks like the root cause of the failed UTs are that we don't wait
until AsyncTable.put()
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-733682994
I just added the following comment:
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1005-R1008
Can
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-733347321
Thank you @apurtell
Can you please review this? @Apache9
This is an automated message from the Apache
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731673410
I made a mistake and the compile in the last QA failed.. Just fixed it and
pushed the latest patch.
This is an
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-731659869
I just changed the patch regarding the following:
- Add testing for Append and keep the last else branch throwing
DoNotRetryIOException
- Use DoNotRetryIOException instead
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-729294452
Ping @Apache9 . Thanks.
This is an automated message from the Apache Git Service.
To respond to the message,
brfrn169 commented on pull request #2630:
URL: https://github.com/apache/hbase/pull/2630#issuecomment-723505852
Can you please review this? @Apache9
This is an automated message from the Apache Git Service.
To respond to
