busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-648637103
these two additional commits are both minor tweaks. @ndimiduk and
@mattf-apache please shout if you'd like to give further feedback. barring that
I'll go ahead with merging after
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-648636537
> > yes your gpg agent has to be running on your local machine before hand.
...
> > I could add an example of forcing a clean start of the gpg-agent, e.g.
gpgconf --kill all &&
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-648600803
force push was just me rebasing to the current HEAD with the changes as they
were. the next commit is a minor issue I found while doing non-docker builds.
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-645125135
> error: object directory /home/vagrant/repos/hbase/.git/objects does not
exist; check .git/objects/info/alternates.
the object directory messages are a side effect of using
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-643723774
> A question: It seems it will require the RM's gpg passphrase at signing
time, which is
> many minutes into the build process. If the RM is off having a cup of
coffee, how
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-643025027
> I'd like to try this out from a vagrant/VirtualBox vm, instead of going
to GCE. thoughts?
I do not know of any reason that would not work. I only did GCE because
Stack's
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-639194124
force push just rebased to current master and took care of a conflict.
This is an automated message from the
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-633096717
Mind taking a look @mattf-apache?
This is an automated message from the Apache Git Service.
To respond to the
busbey commented on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-633096629
I think this is ready now.
This is an automated message from the Apache Git Service.
To respond to the message,
