[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for reminding me. --

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` following your patch for maintainability, thank you very much for

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for reminding. -- This

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-27 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1023827321 @Apache9, ok, I have already introduce a separated test class `TestFanOutOneBlockAsyncDFSOutputHang` for maintainability, thank you very much for remind. -- This is

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-26 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1022813753 @Apache9 , thank you very much, I have already modify my test code following your patch. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] comnetwork edited a comment on pull request #4039: HBASE-26679 Wait on the future returned by FanOutOneBlockAsyncDFSOutp…

2022-01-26 Thread GitBox
comnetwork edited a comment on pull request #4039: URL: https://github.com/apache/hbase/pull/4039#issuecomment-1022813753 @Apache9 , I have improved my test to remove reflection and use Mockito to simulate slow DNs by discarding the message when flushing to dn2 and dn3, I would modify my