[GitHub] [hbase] jojochuang commented on pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-06-16 Thread via GitHub 


jojochuang commented on PR #5189:
URL: https://github.com/apache/hbase/pull/5189#issuecomment-159497

   Well actually the test would fail if it's not "hdfs"
   
   
   `[ERROR]   
TestFSUtils.testSetStoragePolicyDefault:412->verifyNoHDFSApiInvocationForDefaultPolicy:422
 ยป IllegalArgument Invalid URI for NameNode address (check fs.defaultFS): 
failfs://localhost/ is not of scheme 'hdfs'.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] jojochuang commented on pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-20 Thread via GitHub 


jojochuang commented on PR #5189:
URL: https://github.com/apache/hbase/pull/5189#issuecomment-1516671554

   The failed test doesn't look related. @taklwu can you help review this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] jojochuang commented on pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-19 Thread via GitHub 


jojochuang commented on PR #5189:
URL: https://github.com/apache/hbase/pull/5189#issuecomment-1515407953

   Thanks for the tips! Updated checkstyle and also fixed the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org