joshelser commented on a change in pull request #1138: HBASE-22827 Expose
multi-region merge in shell and Admin API
URL: https://github.com/apache/hbase/pull/1138#discussion_r379034894
##########
File path: hbase-shell/src/main/ruby/shell/commands/merge_region.rb
##########
@@ -31,18 +31,42 @@ def help
TestTable,0094429456,1289497600452.527db22f95c8a9e0116f0cc13c680396. then
the encoded region name portion is 527db22f95c8a9e0116f0cc13c680396
+You can either pass the list of regions as comma separated values or as an
+array of regions as shown:
+
Examples:
hbase> merge_region 'FULL_REGIONNAME', 'FULL_REGIONNAME'
- hbase> merge_region 'FULL_REGIONNAME', 'FULL_REGIONNAME', true
+ hbase> merge_region 'FULL_REGIONNAME', 'FULL_REGIONNAME', 'FULL_REGIONNAME',
...
+ hbase> merge_region 'FULL_REGIONNAME', 'FULL_REGIONNAME', 'FULL_REGIONNAME',
..., true
+
+ hbase> merge_region ['FULL_REGIONNAME', 'FULL_REGIONNAME']
+ hbase> merge_region ['FULL_REGIONNAME', 'FULL_REGIONNAME',
'FULL_REGIONNAME', ...]
+ hbase> merge_region ['FULL_REGIONNAME', 'FULL_REGIONNAME',
'FULL_REGIONNAME', ..., true]
hbase> merge_region 'ENCODED_REGIONNAME', 'ENCODED_REGIONNAME'
- hbase> merge_region 'ENCODED_REGIONNAME', 'ENCODED_REGIONNAME', true
+ hbase> merge_region 'ENCODED_REGIONNAME', 'ENCODED_REGIONNAME',
'ENCODED_REGIONNAME', ...
+ hbase> merge_region 'ENCODED_REGIONNAME', 'ENCODED_REGIONNAME',
'ENCODED_REGIONNAME', ..., true
+
+ hbase> merge_region ['ENCODED_REGIONNAME', 'ENCODED_REGIONNAME']
+ hbase> merge_region ['ENCODED_REGIONNAME', 'ENCODED_REGIONNAME',
'ENCODED_REGIONNAME', ...]
+ hbase> merge_region ['ENCODED_REGIONNAME', 'ENCODED_REGIONNAME',
'ENCODED_REGIONNAME', ..., true]
EOF
end
- def command(region_a_name, region_b_name, force = 'false')
- admin.merge_region(region_a_name, region_b_name, force)
+ def command(*args)
+ args = args.flatten.compact
+ args_len = args.length
+ raise(ArgumentError, 'Must pass atleast 2 regions to merge') unless
args_len > 1
Review comment:
nit: "at least"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
