[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635659322 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitValueCompression.java ## @@ -0,0 +1,44 @@ +/** + * Licensed to the

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635657600 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -18,37 +18,117 @@ package

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-17 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r633805051 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,8 @@ message WALHeader { optional bool

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-11 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r630593612 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-11 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r630591194 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629712475 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int