[GitHub] [hbase] ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] TestMasterShutdown#testMasterShutdownBefore…

2020-03-25 Thread GitBox
ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] 
TestMasterShutdown#testMasterShutdownBefore…
URL: https://github.com/apache/hbase/pull/1141#issuecomment-603931441
 
 
   This test failed again for me last night. attaching a log to the jira.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] TestMasterShutdown#testMasterShutdownBefore…

2020-02-13 Thread GitBox
ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] 
TestMasterShutdown#testMasterShutdownBefore…
URL: https://github.com/apache/hbase/pull/1141#issuecomment-585920811
 
 
   Follow-on ticket is https://issues.apache.org/jira/browse/HBASE-23836


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] TestMasterShutdown#testMasterShutdownBefore…

2020-02-11 Thread GitBox
ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] 
TestMasterShutdown#testMasterShutdownBefore…
URL: https://github.com/apache/hbase/pull/1141#issuecomment-584956495
 
 
   > > More digging, will be back.
   > 
   > Is there more to it than fixing the ServerManager initialization? Meaning, 
does the test still fail after my waitFor() fix?
   
   That fixes the test, but I think that's exactly the kind of gap that 
HBASE-8422 was trying to close.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] TestMasterShutdown#testMasterShutdownBefore…

2020-02-11 Thread GitBox
ndimiduk commented on issue #1141: HBASE-23808 [Flakey Test] 
TestMasterShutdown#testMasterShutdownBefore…
URL: https://github.com/apache/hbase/pull/1141#issuecomment-584748786
 
 
   Updated per PR feedback. Also some further restructuring of the test, 
including some learnings from HBASE-23647.
   
   I think there's a real bug here. I can issue a `shutdown` RPC that is 
acknowledged by the master and commences shutdown. However, at least one 
subsystem is not getting the message and continues on. This seems to leave the 
master in a quasi-initialized zombie state. (I believe this is what @bharathv 
was seeing when he added the `waitFor` on the `ServerManager` instance) 
Eventually the 200sec master initialization timeout trips and the test fails.
   
   More digging, will be back.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services