[GitHub] [hbase] ndimiduk commented on pull request #3754: HBASE-26361 Enable OpenTelemetry to be used from developer sandbox
ndimiduk commented on pull request #3754: URL: https://github.com/apache/hbase/pull/3754#issuecomment-946228343 Thanks for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3754: HBASE-26361 Enable OpenTelemetry to be used from developer sandbox
ndimiduk commented on pull request #3754: URL: https://github.com/apache/hbase/pull/3754#issuecomment-946228257 Manual testing confirmed this works for both dev sandbox and bin-tgz. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3754: HBASE-26361 Enable OpenTelemetry to be used from developer sandbox
ndimiduk commented on pull request #3754: URL: https://github.com/apache/hbase/pull/3754#issuecomment-946177258 While creating the master patch, I noticed that the order of jshell configuration and otel configuration are swapped between the two branches. I've updated this patch so that the configuration order on branch-2 matches master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3754: HBASE-26361 Enable OpenTelemetry to be used from developer sandbox
ndimiduk commented on pull request #3754: URL: https://github.com/apache/hbase/pull/3754#issuecomment-944494472 > I think this is good if you test it locally and it could work. Please make sure that we do not miss the commit to master as the PR is for branch-2... @Apache9 It's working for me, but @taklwu has some trouble, so let me sort it out with him. Yes, I'll forward-port to master branch. I'm testing on branch-2 in preparation of 2.5 release process, but I will not forget about master. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
