saintstack commented on a change in pull request #718: HBASE-23155 May NPE when concurrent AsyncNonMetaRegionLocator#updateC… URL: https://github.com/apache/hbase/pull/718#discussion_r334243560
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java ########## @@ -399,4 +399,14 @@ public void testLocateBeforeInOnlyRegion() throws IOException, InterruptedExcept assertArrayEquals(loc.getRegion().getStartKey(), EMPTY_START_ROW); assertArrayEquals(loc.getRegion().getEndKey(), EMPTY_END_ROW); } + + @Test + public void testConcurrentUpdateCachedLocationOnError() throws Exception { + createSingleRegionTable(); + HRegionLocation loc = + getDefaultRegionLocation(TABLE_NAME, EMPTY_START_ROW, RegionLocateType.CURRENT, false) + .get(); + IntStream.range(0, 100).parallel() Review comment: If single-region table, will this produce a null RegionLocation? Should there be something going on in the background clearing tableCache? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services