virajjasani commented on code in PR #5188:
URL: https://github.com/apache/hbase/pull/5188#discussion_r1171885295
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -341,6 +355,14 @@ private static int getWarnResponseSize(Configuration conf)
{
return conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE);
}
+ private static int getWarnResponseTimeScan(Configuration conf) {
Review Comment:
nit: getWarnResponseTimeScan -> getWarnScanResponseTime
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -341,6 +355,14 @@ private static int getWarnResponseSize(Configuration conf)
{
return conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE);
}
+ private static int getWarnResponseTimeScan(Configuration conf) {
+ return conf.getInt(WARN_RESPONSE_TIME_SCAN, getWarnResponseTime(conf));
+ }
+
+ private static int getWarnResponseSizeScan(Configuration conf) {
Review Comment:
nit: getWarnResponseSizeScan -> getWarnScanResponseSize
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -198,6 +200,8 @@ public abstract class RpcServer implements
RpcServerInterface, ConfigurationObse
protected final int maxRequestSize;
protected volatile int warnResponseTime;
protected volatile int warnResponseSize;
+ protected volatile int warnResponseTimeScan;
+ protected volatile int warnResponseSizeScan;
Review Comment:
nit: warnScanResponseTime and warnScanResponseSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
