[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1682195848 The 2nd commit 05795bfc3e338cc8d6a9acab66863868ea3f9d51 was a nit change affecting only docs. The 1st commit has been reviewed by @wchevreuil. Will wait for others for another day for more reviews, else will go ahead and merge, if no concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1682188243 Rebased code to resolve conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1673468858 Gentle ping @wchevreuil, let me know if this revised PR looks good to you. CC: @petersomogyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639760655 > Also, will be creating another ticket as I see there are differences in the hbck2 doc and the command help output, hence we should sync them across all command. Did not piggy back those changes here to keep this PR clean. Raised [HBASE-27980](https://issues.apache.org/jira/browse/HBASE-27980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639744953 Synced the doc. Good for review. @wchevreuil Also, will be creating another ticket as I see there are differences in the hbck2 doc and the command help output, hence we should sync them across all command. Did not piggy back those changes here to keep this PR clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639714043 Hey just realized, need to sync hbck2 doc, please do not merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636853685 Hi @wchevreuil could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636841073 Also while testing, encountered HBASE-27961. Will work on batching for assignment as part of that JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain commented on PR #131: URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636839483 [Following was done to test the code changes: - Build the repo with HBase 2.5.x - Print help to see it works as expected - Create a table with 7070 regions and do full hbase meta repair by dropping meta table data from hdfs - Tested the newly added functionality against a 2.5.x cluster and verified assigns is able to pickup the output - Verified expected number of files are created as per input and data Truncated test logs for reference: ``` $ export HBCK_JAR=hbase-hbck2-1.3.0-SNAPSHOT.jar $ hbase hbck -j $HBCK_JAR usage: HBCK2 [OPTIONS] COMMAND Options: -d,--debug run with debug output -h,--helpoutput this help message -p,--hbase.zookeeper.property.clientPortport of hbase ensemble -q,--hbase.zookeeper.quorum hbase ensemble -s,--skipskip hbase version check (PleaseHoldException) -v,--version this hbck2 version -z,--zookeeper.znode.parent parent znode of hbase ensemble Command: addFsRegionsMissingInMeta [OPTIONS] [...|-i ...] Options: -i,--inputFiles take one or more files of namespace or table names -o,--outputFile name/prefix of the file(s) to dump region names -n,--numLines number of lines to be written to each output file To be used when regions missing from hbase:meta but directories are present still in HDFS. Can happen if user has run _hbck1_ 'OfflineMetaRepair' against an hbase-2.x cluster. Needs hbase:meta to be online. For each table name passed as parameter, performs diff between regions available in hbase:meta and region dirs on HDFS. Then for dirs with no hbase:meta matches, it reads the 'regioninfo' metadata file and re-creates given region in hbase:meta. Regions are re-created in 'CLOSED' state in the hbase:meta table, but not in the Masters' cache, and they are not assigned either. To get these regions online, run the HBCK2 'assigns'command printed when this command-run completes. NOTE: If using hbase releases older than 2.3.0, a rolling restart of HMasters is needed prior to executing the set of 'assigns' output. An example adding missing regions for tables 'tbl_1' in the default namespace, 'tbl_2' in namespace 'n1' and for all tables from namespace 'n2': $ HBCK2 addFsRegionsMissingInMeta default:tbl_1 n1:tbl_2 n2 Returns HBCK2 an 'assigns' command with all re-inserted regions. SEE ALSO: reportMissingRegionsInMeta SEE ALSO: fixMeta If -i or --inputFiles is specified, pass one or more input file names. Each file contains , one per line. For example: $ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2 If -o or --outputFile is specified, the output file(s) can be passed as input to assigns command via -i or -inputFiles option. If -n or --numLines is specified, and say it is set to 100, this will create files with prefix as value passed by -o or --outputFile option. Each file will have 100 region names (max.), one per line. For example: $ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2 -o outputFilePrefix -n 100 But if -n is not specified, but -o is specified, it will dump all region names in a single file, one per line. For example: $ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2 -o outputFileName assigns [OPTIONS] [...|-i ...] . . $ cat namesapce.txt hbase:namespace $ cat acl.txt hbase:acl hbase hbck -j $HBCK_JAR addFsRegionsMissingInMeta -i namesapce.txt acl.txt -o test/system_regions.txt Dumping region names to file: /tmp/test/system_regions.txt Regions re-added into Meta: 2 WARNING: 2 regions were added to META, but these are not yet on Masters cache. You need to restart Masters, then run hbck2 'assigns' command below: assigns 708ade6cca88d7a2b8d7e8b045b1c715 8343b51276a70f081f6574c1a6cb5296 $ cat test/system_regions.txt 708ade6cca88d7a2b8d7e8b045b1c715 8343b51276a70f081f6574c1a6cb5296 $ hbase hbck -j $HBCK_JAR assigns -i test/system_regions.txt [4, 5] $ hbase hbck -j $HBCK_JAR addFsRegionsMissingInMeta -o test/user_regions.txt -n 1000 default Dumping region names to file: /tmp/test/user_regions.txt.0 Dumping region names to file: /tmp/test/user_regions.txt.1 Dumping region names to file: /tmp/test/user_regions.txt.2 Dumping region names to file:
