Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-02-20 Thread via GitHub
lfrancke commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1954881153 Yeah, I did start a [thread](https://lists.apache.org/thread/smz4ttn5fdrqnow94jrhz6sbt2crs8kj) on the mailing list and need to get around to update this PR. -- This is an automated

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-02-20 Thread via GitHub
jojochuang commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-195483 Yeah makes sense, even 3.0 is released. the last 1.x release was 2+ years ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879848900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879826428 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879755335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-25 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1869111842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-25 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1869095188 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-25 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1869010776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-25 Thread via GitHub
Apache9 commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1868989421 > The test failures seem unrelated. Can someone explain to me what the difference between all those Jenkins runs is? The general check is mostly for testing compiling and install.

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-12 Thread via GitHub
lfrancke commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1851976067 The test failures seem unrelated. Can someone explain to me what the difference between all those Jenkins runs is? -- This is an automated message from the Apache Git Service. To

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-07 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1845339618 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-07 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1845140933 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1844768378 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1844557629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1844404295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1843932731 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2023-12-06 Thread via GitHub
lfrancke opened a new pull request, #5566: URL: https://github.com/apache/hbase/pull/5566 - Adds settings that are available in async-profiler 2.0 and later and removes those that don't exist anymore. - Adds support for the itimer event, renames "branches" to "branch-instructions" -