Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
ndimiduk merged PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
ndimiduk commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505692026 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This project is for Apache HBase internal use. Included libs +> and/or their versions are subject to change at the dictate of hbase without +> regard to the concern of others! + +We have a number of submodules, one per ornery lib -- protobuf, netty, -- Review Comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
NihalJain commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505527140 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This project is for Apache HBase internal use. Included libs +> and/or their versions are subject to change at the dictate of hbase without +> regard to the concern of others! + +We have a number of submodules, one per ornery lib -- protobuf, netty, -- +where we need special-handling and then a bucket for all the rest, +hbase-shaded-miscellaneous. This latter includes protobuf-util, gson, and guava. + +General philosophy is many modules rather than a few fat ones so we can keep +dependency narrow; a fat jar would put a load of unnecessaries on the +CLASSPATH. The hbase-shaded-miscellaneous is a sort of all-the-rest but it +is also libs that depend on each other and are awkward to disentangle. + +All shading is done using the same relocation offset of +org.apache.hbase.thirdparty. We add this prefix to the relocated thirdparty +library class names. + +See the pom.xml for the explicit version of each third-party lib included. + +Note that in hbase-shaded-protobuf, we unzip the protobuf jar to src/main/java +rather than to a dir under target because the jar plugin wants src here (its +hard to convince it otherwise). We also apply some patches. Current set are: + +``` +HBASE-15789_V2.patch +HBASE-17087.patch +HBASE-17239.patch +``` + +Ideally we would be pushing this set up into protobuf project. + +Note that this project requires JDK8. This is because a bunch of the code we +have in hbase-unsafe is using old APIs that have been removed from more +modern JDKs. Due to a bug in JDK, we cannot generate this code using a more +modern version of the JDK. See +[HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details. Review Comment: Ah I hit https://issues.apache.org/jira/browse/HBASE-28380, while trying to build with JDK17. This doc helps me understand why we have hbase-unsafe module and how to release. Very useful. Thanks a ton :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
Apache9 commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505264727 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This project is for Apache HBase internal use. Included libs +> and/or their versions are subject to change at the dictate of hbase without +> regard to the concern of others! + +We have a number of submodules, one per ornery lib -- protobuf, netty, -- Review Comment: OK, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
busbey commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505263844 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This project is for Apache HBase internal use. Included libs +> and/or their versions are subject to change at the dictate of hbase without +> regard to the concern of others! + +We have a number of submodules, one per ornery lib -- protobuf, netty, -- Review Comment: It's a way to say "etcetera" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
Apache9 commented on code in PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#discussion_r1505261164 ## README.md: ## @@ -0,0 +1,115 @@ +# HBase Thirdparty + + +This project packages relocated third-party libraries used by Apache HBase. + +> DISCLAIMER: This project is for Apache HBase internal use. Included libs +> and/or their versions are subject to change at the dictate of hbase without +> regard to the concern of others! + +We have a number of submodules, one per ornery lib -- protobuf, netty, -- Review Comment: What does the '' mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
Apache-HBase commented on PR #113: URL: https://github.com/apache/hbase-thirdparty/pull/113#issuecomment-1966996039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 18s | ASF License check generated no output? | | | | 2m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-113/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/113 | | Optional Tests | dupname asflicense markdownlint | | uname | Linux 90af66ffd0c2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 293203f | | Max. process+thread count | 8 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-113/1/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28407 [thirdparty] Update release instructions [hbase-thirdparty]
ndimiduk opened a new pull request, #113: URL: https://github.com/apache/hbase-thirdparty/pull/113 @Apache9 @busbey This is the processes that I (eventually) sorted out. Does it look about right from your recollection? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
