Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117204449
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
Umeshkumar9414 commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117121965
I tried to write UT for this by submitting 2 SplitWALProcedure, one before
master failover and one after failover. But Till the time another procedure
completes on RegionServer stub
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090334812
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 27s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090324948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 35s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2090248908
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 56s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2089840560
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087729812
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087725557
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2087690526
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2086882878
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Umeshkumar9414 commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2084727309
The reason for the last build failure is `on project hbase-server: There was
a timeout in the fork -> [Help 1]`.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083848185
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083842999
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083840692
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2083502346
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1583578291
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1581817417
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1580528932
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075944485
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075941381
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075908528
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
apurtell commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1578559171
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2075582880
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 19s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1576598653
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1575047329
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1575047329
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574183543
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574170676
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574170676
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574142648
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1574142648
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1573285964
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -113,17 +117,20 @@ protected synchronized void
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r156192
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050759162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050749066
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050737037
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2050503644
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561567738
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561516811
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561516811
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -80,6 +81,8 @@ public abstract class
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561513882
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Umeshkumar9414 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1561491798
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046499502
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046489855
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046478948
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache9 commented on code in PR #5816:
URL: https://github.com/apache/hbase/pull/5816#discussion_r1558779533
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerRemoteProcedure.java:
##
@@ -137,6 +140,10 @@ synchronized void
Apache-HBase commented on PR #5816:
URL: https://github.com/apache/hbase/pull/5816#issuecomment-2046231195
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Umeshkumar9414 opened a new pull request, #5816:
URL: https://github.com/apache/hbase/pull/5816
ServerRemoteProcedure does not have its own serializing implementation, so
had to make changes in all the sub-procedures.
--
This is an automated message from the Apache Git Service.
To
48 matches
Mail list logo