Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty merged PR #5802: URL: https://github.com/apache/hbase/pull/5802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057035828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057034754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057033987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2057032956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2056964975 Ruined formatting by spotless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055233034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055233717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055227136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2055225640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on code in PR #5802: URL: https://github.com/apache/hbase/pull/5802#discussion_r1561995476 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java: ## @@ -59,8 +62,25 @@ public ScannerResource(TableResource tableResource) throws

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on code in PR #5802: URL: https://github.com/apache/hbase/pull/5802#discussion_r1561995476 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java: ## @@ -59,8 +62,25 @@ public ScannerResource(TableResource tableResource) throws

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on code in PR #5802: URL: https://github.com/apache/hbase/pull/5802#discussion_r1561996353 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java: ## @@ -59,8 +62,25 @@ public ScannerResource(TableResource tableResource) throws

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

ankitsinghal commented on code in PR #5802: URL: https://github.com/apache/hbase/pull/5802#discussion_r1561801139 ## hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java: ## @@ -59,8 +62,25 @@ public ScannerResource(TableResource tableResource) throws

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2046618591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2046615476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2046609848 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2046607588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2045670851 Oops, this is actually two commits. I will remove the sticky stuff before commit, as that's a different ticket. (HBASE-28504) -- This is an automated message from the Apache Git

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044698300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044701668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044693170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044692826 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044567536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044565904 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044563034 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044562602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044380918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044379683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044378785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

Apache-HBase commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044377748 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty commented on PR #5802: URL: https://github.com/apache/hbase/pull/5802#issuecomment-2044329576 Using Caffeine instead of Guava Cache, as recommended by Guava. Caffeine is already a dependency. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] HBASE-28504 Implement eviction logic for scanners in Rest APIs to pre… [hbase]

stoty opened a new pull request, #5802: URL: https://github.com/apache/hbase/pull/5802 …vent scanner leakage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To