[jira] [Comment Edited] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483461#comment-16483461 ] Allan Yang edited comment on HBASE-16290 at 5/22/18 4:10 AM: - [~Sreeram], there is a problem caused by this issue. Except the Java's LinkedBlockingQueue, the other queue implementations like BoundedPriorityBlockingQueue and AdaptiveLifoCoDelCallQueue don't implement the method {code:java} public Iterator iterator() {code} this will cause a UnsupportedOperationException exception in getCallQueueInfo(). Which can be easily be reproduced by the UT testCallQueueInfo while adding a conf {code} conf.set("hbase.ipc.server.callqueue.type", "deadline"); {code} {code} java.lang.UnsupportedOperationException at org.apache.hadoop.hbase.util.BoundedPriorityBlockingQueue.iterator(BoundedPriorityBlockingQueue.java:285) at org.apache.hadoop.hbase.ipc.RpcExecutor.getCallQueueCountsSummary(RpcExecutor.java:166) at org.apache.hadoop.hbase.ipc.SimpleRpcScheduler.getCallQueueInfo(SimpleRpcScheduler.java:241) at org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler.testCallQueueInfo(TestSimpleRpcScheduler.java:164) {code} was (Author: allan163): [~Sreeram], this patch has a problem. Except the Java's LinkedBlockingQueue, the other queue implementations like BoundedPriorityBlockingQueue and AdaptiveLifoCoDelCallQueue don't implement the method {code:java} public Iterator iterator() {code} this will cause a UnsupportedOperationException exception in getCallQueueInfo(). Which can be easily be reproduced by the UT testCallQueueInfo while adding a conf {code} conf.set("hbase.ipc.server.callqueue.type", "deadline"); {code} {code} java.lang.UnsupportedOperationException at org.apache.hadoop.hbase.util.BoundedPriorityBlockingQueue.iterator(BoundedPriorityBlockingQueue.java:285) at org.apache.hadoop.hbase.ipc.RpcExecutor.getCallQueueCountsSummary(RpcExecutor.java:166) at org.apache.hadoop.hbase.ipc.SimpleRpcScheduler.getCallQueueInfo(SimpleRpcScheduler.java:241) at org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler.testCallQueueInfo(TestSimpleRpcScheduler.java:164) {code} > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian >Priority: Major > Labels: beginner > Fix For: 2.0.0 > > Attachments: DebugDump_screenshot.png, HBASE-16290.master.001.patch, > HBASE-16290.master.002.patch, HBASE-16290.master.003.patch, > HBASE-16290.master.004.patch, HBASE-16290.master.005.patch, > HBASE-16290.master.006.patch, HBASE-16290.master.007.patch, > HBASE-16290.master.008.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217200#comment-16217200 ] stack edited comment on HBASE-16290 at 10/24/17 4:38 PM: - Nice one. Added it to 'significant changes list' for hbase2. was (Author: stack): Nice one. > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: DebugDump_screenshot.png, HBASE-16290.master.001.patch, > HBASE-16290.master.002.patch, HBASE-16290.master.003.patch, > HBASE-16290.master.004.patch, HBASE-16290.master.005.patch, > HBASE-16290.master.006.patch, HBASE-16290.master.007.patch, > HBASE-16290.master.008.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213826#comment-16213826 ] Sreeram Venkatasubramanian edited comment on HBASE-16290 at 10/21/17 9:34 AM: -- [~chia7712], I have uploaded the patch to the review board - [https://reviews.apache.org/r/63201/] was (Author: sreeram): [~chia7712]], I have uploaded the patch to the review board - [https://reviews.apache.org/r/63201/] > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: DebugDump_screenshot.png, HBASE-16290.master.001.patch, > HBASE-16290.master.002.patch, HBASE-16290.master.003.patch, > HBASE-16290.master.004.patch, HBASE-16290.master.005.patch, > HBASE-16290.master.006.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-16290) Dump summary of callQueue content; can help debugging
[ https://issues.apache.org/jira/browse/HBASE-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179094#comment-16179094 ] Sreeram Venkatasubramanian edited comment on HBASE-16290 at 9/25/17 2:27 PM: - Hi [~chia7712], Renamed as per Yetus naming convention ! was (Author: sreeram): Renamed as per Yetus naming convention. > Dump summary of callQueue content; can help debugging > - > > Key: HBASE-16290 > URL: https://issues.apache.org/jira/browse/HBASE-16290 > Project: HBase > Issue Type: Bug > Components: Operability >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Sreeram Venkatasubramanian > Labels: beginner > Fix For: 2.0.0 > > Attachments: 0001-Changes-for-HBASE-16290.patch.old, > 0001-Dump-call-queue-summaries.patch.old, DebugDump_screenshot.png, > HBASE-16290.master.001.patch, Sample Summary.txt > > > Being able to get a clue what is in a backedup callQueue could give insight > on what is going on on a jacked server. Just needs to summarize count, sizes, > call types. Useful debugging. In a servlet? -- This message was sent by Atlassian JIRA (v6.4.14#64029)