[jira] [Comment Edited] (HBASE-19338) Performance regression in RegionServerRpcQuotaManager to get ugi

2017-11-24 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265168#comment-16265168
 ] 

Ted Yu edited comment on HBASE-19338 at 11/25/17 2:07 AM:
--

https://builds.apache.org/job/PreCommit-HBASE-Build/9997/console :
{code}
08:50:46 Modes:  MultiJDK  Jenkins  Robot  Docker  ResetRepo  UnitTests 
08:50:46 Processing: HBASE-19338
08:50:47 ERROR: Unsure how to process HBASE-19338.
{code}
Looks like we may not get QA back today.

Lijin:
Next week people in US are returning to work.
You can wait till QA bot becomes functional again.

Thanks


was (Author: yuzhih...@gmail.com):
https://builds.apache.org/job/PreCommit-HBASE-Build/9997/console :
{code}
08:50:46 Modes:  MultiJDK  Jenkins  Robot  Docker  ResetRepo  UnitTests 
08:50:46 Processing: HBASE-19338
08:50:47 ERROR: Unsure how to process HBASE-19338.
{code}
Looks like we may not get QA back today.

Lijin:
After verifying a few Visibility and AccessController related tests, you can go 
with the commit.

Thanks

> Performance regression in RegionServerRpcQuotaManager to get ugi 
> -
>
> Key: HBASE-19338
> URL: https://issues.apache.org/jira/browse/HBASE-19338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: binlijin
>Assignee: binlijin
>Priority: Critical
> Attachments: 19338.master.003.patch, 19338.master.003.patch, 
> HBASE-19338.master.001.patch, HBASE-19338.master.002.patch
>
>
> we find hbase-2.0.0-beta-1.SNAPSHOT have performance regression with yscb put 
>  and have some finding.  
> {code}
> "RpcServer.default.FPBQ.Fifo.handler=131,queue=17,port=16020" #245 daemon 
> prio=5 os_prio=0 tid=0x7fc82b22e000 nid=0x3a5db waiting for monitor entry 
> [0x7fc50fafa000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:647)
> - waiting to lock <0x7fcaedc20830> (a java.lang.Class for 
> org.apache.hadoop.security.UserGroupInformation)
> at 
> org.apache.hadoop.hbase.security.User$SecureHadoopUser.(User.java:264)
> at org.apache.hadoop.hbase.security.User.getCurrent(User.java:162)
> at 
> org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:179)
> at 
> org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:162)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2521)
> at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41560)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (HBASE-19338) Performance regression in RegionServerRpcQuotaManager to get ugi

2017-11-23 Thread binlijin (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264848#comment-16264848
 ] 

binlijin edited comment on HBASE-19338 at 11/24/17 12:38 AM:
-

bq.  Does User.getCurrent throw any exceptions? If no, we can use 
orElseGet(User::getCurrent), else the only solution is to write the if 
condition explicitly like the patch here.
Yes, User.getCurrent throws IOException, looks like we can not use orElseGet 
here.


was (Author: aoxiang):
bp. Does User.getCurrent throw any exceptions? If no, we can use 
orElseGet(User::getCurrent), else the only solution is to write the if 
condition explicitly like the patch here.
Yes, User.getCurrent throws IOException, looks like we can not use orElseGet 
here.

> Performance regression in RegionServerRpcQuotaManager to get ugi 
> -
>
> Key: HBASE-19338
> URL: https://issues.apache.org/jira/browse/HBASE-19338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-beta-2
>Reporter: binlijin
>Assignee: binlijin
>Priority: Critical
> Attachments: 19338.master.003.patch, HBASE-19338.master.001.patch, 
> HBASE-19338.master.002.patch
>
>
> we find hbase-2.0.0-beta-1.SNAPSHOT have performance regression with yscb put 
>  and have some finding.  
> {code}
> "RpcServer.default.FPBQ.Fifo.handler=131,queue=17,port=16020" #245 daemon 
> prio=5 os_prio=0 tid=0x7fc82b22e000 nid=0x3a5db waiting for monitor entry 
> [0x7fc50fafa000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:647)
> - waiting to lock <0x7fcaedc20830> (a java.lang.Class for 
> org.apache.hadoop.security.UserGroupInformation)
> at 
> org.apache.hadoop.hbase.security.User$SecureHadoopUser.(User.java:264)
> at org.apache.hadoop.hbase.security.User.getCurrent(User.java:162)
> at 
> org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:179)
> at 
> org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:162)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2521)
> at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41560)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)