[jira] [Comment Edited] (HBASE-20838) Move all setStorage related UT cases from TestFSUtils to TestCommonFSUtils

2018-07-09 Thread Yu Li (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537939#comment-16537939
 ] 

Yu Li edited comment on HBASE-20838 at 7/10/18 3:32 AM:


btw, I've tested the shell lines locally and could assure the correctness, but 
would like to know whether could test Yetus locally, or maybe simply trigger 
HadoopQA could do the trick (already some changes in CommonFSUtils so if the 
script works it will trigger the hbase-server test)? Thanks.


was (Author: carp84):
btw, I've tested the shell lines locally and could assure the correctness, but 
would like to know whether could test Yetus locally, or maybe making some fake 
change in hbase-server in patch here and trigger HadoopQA could do the trick? 
Thanks.

> Move all setStorage related UT cases from TestFSUtils to TestCommonFSUtils
> --
>
> Key: HBASE-20838
> URL: https://issues.apache.org/jira/browse/HBASE-20838
> Project: HBase
>  Issue Type: Test
>Reporter: Yu Li
>Assignee: Yu Li
>Priority: Major
> Attachments: HBASE-20838.patch
>
>
> As per 
> [discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
>  in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the 
> test should be in TestCommonFSUtils



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20838) Move all setStorage related UT cases from TestFSUtils to TestCommonFSUtils

2018-07-06 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-20838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534786#comment-16534786
 ] 

Sean Busbey edited comment on HBASE-20838 at 7/6/18 12:54 PM:
--

we should also have a note in CommonFSUtils that its functionality is tested in 
hbase-server's TestFSUtils and that precommit is going to run the hbase-server 
tests if the file changes, since we already know hbase-server tests are a large 
time hit and it'll be surprising.


was (Author: busbey):
we should also have a note in CommonFSUtils that its functionality is tested in 
hbase-server's TestFSUtils and that precommit is going to run the hbase-server 
tests if the file changes, since we already know hbase-server tests is a large 
time hit and it'll be surprising.

> Move all setStorage related UT cases from TestFSUtils to TestCommonFSUtils
> --
>
> Key: HBASE-20838
> URL: https://issues.apache.org/jira/browse/HBASE-20838
> Project: HBase
>  Issue Type: Test
>Reporter: Yu Li
>Assignee: Yu Li
>Priority: Major
>
> As per 
> [discussed|https://issues.apache.org/jira/browse/HBASE-20691?focusedCommentId=16517662=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16517662]
>  in HBASE-20691, since the setStoragePolicy code is in CommonFSUtils, the 
> test should be in TestCommonFSUtils



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)