[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708802#comment-16708802
 ] 

Sean Busbey edited comment on HBASE-21547 at 12/4/18 2:51 PM:
--------------------------------------------------------------

It was intentional at first, because we only had a flaky list from master. Then 
it was "let's do this later" because I was out of time for working on updating 
the flaky infra.

 

If we have a branch at that point, updating precommit to use the corresponding 
flaky list would be great. I'm not sure if it makes HBASE-19265 more or less 
pressing. Since I'm usually concerned about branches that aren't master, 
probably more pressing for me. :)


was (Author: busbey):
It was intentional at first, because we only had a flaky list from master. Then 
it was "let's do this later" because I was out of time for working on updating 
the flaky infra.

 

If we have a branch at that point, updating it to use the corresponding flaky 
list would be great. I'm not sure if it makes HBASE-19265 more or less 
pressing. Since I'm usually concerned about branches that aren't master, 
probably more pressing for me. :)

> Precommit uses master flaky list for other branches
> ---------------------------------------------------
>
>                 Key: HBASE-21547
>                 URL: https://issues.apache.org/jira/browse/HBASE-21547
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Peter Somogyi
>            Priority: Major
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06      0K                                                       100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to