[jira] [Comment Edited] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors

2019-04-16 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819389#comment-16819389
 ] 

Lars Hofhansl edited comment on HBASE-22235 at 4/16/19 6:42 PM:


The constants need to be the public in OperationStatus, which you have in the 
branch-1 patch but not the master patch - perhaps I'm missing something in the 
master branch...?


was (Author: lhofhansl):
The constants need to be the public in OperationStatus.

> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party 
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-22235-branch-1.patch, HBASE-22235.patch, 
> HBASE-22235.patch
>
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors. 
> OperationStatus and OperationStatusCode should have the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors

2019-04-16 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819242#comment-16819242
 ] 

Andrew Purtell edited comment on HBASE-22235 at 4/16/19 4:40 PM:
-

Precommit passed.

[~lhofhansl] you wanted this, right? Please review

 


was (Author: apurtell):
Precommit passed.

[~lhofhansl] you wanted this, right? Please +1

 

> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party 
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-22235-branch-1.patch, HBASE-22235.patch, 
> HBASE-22235.patch
>
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors. 
> OperationStatus and OperationStatusCode should have the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)