[jira] [Comment Edited] (HBASE-24516) Parameter pass incorrectly when refactor SecureBulkLoadClient

2020-06-08 Thread Wellington Chevreuil (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128052#comment-17128052
 ] 

Wellington Chevreuil edited comment on HBASE-24516 at 6/8/20, 9:14 AM:
---

Could you be more specific on why you are proposing such change? And the value 
you are modifying was not introduced by HBASE-23136 patch, it was already 
passing hardcoded _false_ value prior to HBASE-23136, if you look at the patch 
applied, it just added another parameter to the calling method, adjusting the 
callee accordingly, so please rectify this Jira descrtiption.

 

 


was (Author: wchevreuil):
Could you be more specific on why you are proposed such change? And the value 
you are modifying was not introduced by HBASE-23136 patch, it was already 
passing hardcoded _false_ value prior to HBASE-23136, if you look at the patch 
applied, it just added another parameter to the calling method, adjusting the 
callee accordingly, so please rectify this Jira descrtiption.

 

 

> Parameter pass incorrectly when refactor SecureBulkLoadClient
> -
>
> Key: HBASE-24516
> URL: https://issues.apache.org/jira/browse/HBASE-24516
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 2.2.2, 2.2.5
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Attachments: HBASE-24516.branch-2.2.patch
>
>
> Parameter pass incorrectly when refactor SecureBulkLoadClient started in 
> HBASE-23136.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-24516) Parameter pass incorrectly when refactor SecureBulkLoadClient

2020-06-08 Thread Qilin Cao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127938#comment-17127938
 ] 

Qilin Cao edited comment on HBASE-24516 at 6/8/20, 8:11 AM:


Submit a patch! thks!


was (Author: qilin cao):
commit a patch! thks!

> Parameter pass incorrectly when refactor SecureBulkLoadClient
> -
>
> Key: HBASE-24516
> URL: https://issues.apache.org/jira/browse/HBASE-24516
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 2.2.2, 2.2.5
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Attachments: HBASE-24516.branch-2.2.patch
>
>
> Parameter pass incorrectly when refactor SecureBulkLoadClient started in 
> HBASE-23136.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)