[jira] [Comment Edited] (HBASE-26124) Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2

2021-08-04 Thread Tak-Lon (Stephen) Wu (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393493#comment-17393493
 ] 

Tak-Lon (Stephen) Wu edited comment on HBASE-26124 at 8/4/21, 11:09 PM:


the [nightly tests of import 
tsv|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/artifact/output-integration/hadoop-2/mr-importtsv.err/*view*/]
 were failing because HBASE-25811 is also required for the entire feature of 
HBASE-22120, I reverted the direct commits of HBASE-26124 and HBASE-26125 from 
branch-2 (apologized if I should not push the revert directly but I found most 
of the previously reverts did not come with a new PR ID, such I assumed the 
clean revert should be able to push directly, anyone please correct me if I'm 
wrong and I will pick up the right operation next time)


was (Author: taklwu):
the nightly tests of import tsv were failing because HBASE-25811 is also 
required for the entire feature of HBASE-22120, I reverted the direct commits 
of HBASE-26124 and HBASE-26125 from branch-2 (apologized if I should not push 
the revert directly but I found most of the previously reverts did not come 
with a new PR ID, such I assumed the clean revert should be able to push 
directly, anyone please correct me if I'm wrong and I will pick up the right 
operation next time)

> Backport HBASE-25373 "Remove HTrace completely in code base and try to make 
> use of OpenTelemetry" to branch-2
> -
>
> Key: HBASE-26124
> URL: https://issues.apache.org/jira/browse/HBASE-26124
> Project: HBase
>  Issue Type: Sub-task
>  Components: tracing
>Affects Versions: 2.5.0, 2.3.5, 2.4.5
>Reporter: Tak-Lon (Stephen) Wu
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
> Fix For: 2.5.0
>
>
> [1/17 commits of 
> HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], backporting 
> HBASE-25373 Remove HTrace completely in code base and try to make use of 
> OpenTelemetry
> We will need to remove some unimplemented tracing in 
> AsyncRequestFutureImpl#getNewMultiActionRunnable that master branch does not 
> have it and also upstream in master does not implement TraceRunnable with 
> OpenTelemetry plugin
> the original commit on master is 
> https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-26124) Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2

2021-07-26 Thread Tak-Lon (Stephen) Wu (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17387753#comment-17387753
 ] 

Tak-Lon (Stephen) Wu edited comment on HBASE-26124 at 7/27/21, 4:43 AM:


I'm targeting for next 2.5.x release, so, should be backporting them all within 
1 or 2 weeks if reviews go fast enough, otherwise, please let me know if I 
should also have a feature branch for HBASE-25853 or a single PR with all the 
commits with new JIRA #ID


was (Author: taklwu):
I'm targeting for next 2.5.x release, so, should be backporting them all within 
1 or 2 weeks if reviews go fast enough, otherwise, please let me know if I 
should also have a feature branch for HBASE-25853 

> Backport HBASE-25373 "Remove HTrace completely in code base and try to make 
> use of OpenTelemetry" to branch-2
> -
>
> Key: HBASE-26124
> URL: https://issues.apache.org/jira/browse/HBASE-26124
> Project: HBase
>  Issue Type: Sub-task
>  Components: tracing
>Affects Versions: 2.5.0
>Reporter: Tak-Lon (Stephen) Wu
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
>
> [1/17 commits of 
> HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], backporting 
> HBASE-25373 Remove HTrace completely in code base and try to make use of 
> OpenTelemetry
> We will need to remove some unimplemented tracing in 
> AsyncRequestFutureImpl#getNewMultiActionRunnable that master branch does not 
> have it and also upstream in master does not implement TraceRunnable with 
> OpenTelemetry plugin
> the original commit on master is 
> https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)