[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878567#comment-13878567 ] Nicolas Liochon commented on HBASE-10375: - Committed to .99, .98, .96. Thanks, lads. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878651#comment-13878651 ] Hudson commented on HBASE-10375: SUCCESS: Integrated in HBase-TRUNK #4848 (See [https://builds.apache.org/job/HBase-TRUNK/4848/]) HBASE-10375 hbase-default.xml hbase.status.multicast.address.port does not match code (nkeywal: rev 1560319) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/trunk/hbase-common/src/main/resources/hbase-default.xml hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878735#comment-13878735 ] Hudson commented on HBASE-10375: FAILURE: Integrated in hbase-0.96 #267 (See [https://builds.apache.org/job/hbase-0.96/267/]) HBASE-10375 hbase-default.xml hbase.status.multicast.address.port does not match code (nkeywal: rev 1560322) * /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/branches/0.96/hbase-common/src/main/resources/hbase-default.xml hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878748#comment-13878748 ] Hudson commented on HBASE-10375: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #96 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/96/]) HBASE-10375 hbase-default.xml hbase.status.multicast.address.port does not match code (nkeywal: rev 1560320) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/branches/0.98/hbase-common/src/main/resources/hbase-default.xml hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879099#comment-13879099 ] Hudson commented on HBASE-10375: SUCCESS: Integrated in HBase-0.98 #103 (See [https://builds.apache.org/job/HBase-0.98/103/]) HBASE-10375 hbase-default.xml hbase.status.multicast.address.port does not match code (nkeywal: rev 1560320) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/branches/0.98/hbase-common/src/main/resources/hbase-default.xml hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879365#comment-13879365 ] Hudson commented on HBASE-10375: FAILURE: Integrated in hbase-0.96-hadoop2 #184 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/184/]) HBASE-10375 hbase-default.xml hbase.status.multicast.address.port does not match code (nkeywal: rev 1560322) * /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/branches/0.96/hbase-common/src/main/resources/hbase-default.xml hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Fix For: 0.98.0, 0.96.2, 0.99.0 Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877498#comment-13877498 ] Nicolas Liochon commented on HBASE-10375: - I was about to commit, but: Should we go for hbase.status.multicast.port' or hbase.status.multicast.address.port ? The ip address is named hbase.status.multicast.address.ip hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877567#comment-13877567 ] stack commented on HBASE-10375: --- Sounds like hbase.status.multicast.address.port would be following convention so +1 hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877664#comment-13877664 ] Andrew Purtell commented on HBASE-10375: +1 for hbase.status.multicast.address.port hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch, 10375.v2.96-98.patch, 10375.v2.trunk.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876534#comment-13876534 ] Nicolas Liochon commented on HBASE-10375: - Yep, it's a typo. The code is right. This can be changed: if someone listens on the wrong port, its mttr will be decreased, but nothing else will be broken, and it won't impact the other nodes. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876562#comment-13876562 ] stack commented on HBASE-10375: --- +1 on all patches. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876748#comment-13876748 ] Jonathan Hsieh commented on HBASE-10375: Hey, [~nkeywal], we need to change the property name in the hbase-defaults.xml too -- hbase.status.multicast.address.port != hbase.status.multicast.port. +1 when the change is done to the hbase-defaults.xml files. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876823#comment-13876823 ] Andrew Purtell commented on HBASE-10375: +1 after what Jon says. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh Assignee: Nicolas Liochon Attachments: 10375.v1.98-96.patch, 10375.v1.patch In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875126#comment-13875126 ] Andrew Purtell commented on HBASE-10375: 60100 or 16100 ? hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10375) hbase-default.xml hbase.status.multicast.address.port does not match code
[ https://issues.apache.org/jira/browse/HBASE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875131#comment-13875131 ] Jonathan Hsieh commented on HBASE-10375: I committed HBASE-10123 to trunk only so i believe: * all should say hbase.status.multicast.port instead of hbase.status.multicast.address.port * 0.96/0.98 should be 60100 * trunk should be 16100 We should get [~nkeywal] to take a quick look to verify this. hbase-default.xml hbase.status.multicast.address.port does not match code - Key: HBASE-10375 URL: https://issues.apache.org/jira/browse/HBASE-10375 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: Jonathan Hsieh In hbase-default.xml {code} + property +namehbase.status.multicast.address.port/name +value6100/value +description + Multicast port to use for the status publication by multicast. +/description + /property {code} In HConstants it was 60100. {code} public static final String STATUS_MULTICAST_PORT = hbase.status.multicast.port; public static final int DEFAULT_STATUS_MULTICAST_PORT = 16100; {code} (it was 60100 in the code for 0.96 and 0.98.) I lean towards going with the code as opposed to the config file. -- This message was sent by Atlassian JIRA (v6.1.5#6160)