[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-03-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919708#comment-13919708 ] Lars Hofhansl commented on HBASE-10625: --- I'll chop away at this as I get time. This

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-03-04 Thread Jean-Marc Spaggiari (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919718#comment-13919718 ] Jean-Marc Spaggiari commented on HBASE-10625: - When you will be sure it's

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-03-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919754#comment-13919754 ] Lars Hofhansl commented on HBASE-10625: --- Will do. Need to reason through the logic

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-03-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1391#comment-1391 ] Lars Hofhansl commented on HBASE-10625: --- Nah. Doesn't work as is. The reason is

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914360#comment-13914360 ] Anoop Sam John commented on HBASE-10625: bq.It's less efficient than this early

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914808#comment-13914808 ] Lars Hofhansl commented on HBASE-10625: --- Hmm... Running the tests again on my work

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914830#comment-13914830 ] Lars Hofhansl commented on HBASE-10625: --- I have no explanation. At home I have

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914862#comment-13914862 ] Lars Hofhansl commented on HBASE-10625: --- With more careful testing, I see about a

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914875#comment-13914875 ] stack commented on HBASE-10625: --- [~lhofhansl] You see [~anoop.hbase] comment above? Patch

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914971#comment-13914971 ] Andrew Purtell commented on HBASE-10625: +1 for 0.98 Remove unnecessary key

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915237#comment-13915237 ] Lars Hofhansl commented on HBASE-10625: --- Testing this is hard it seems. I wrote a

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915262#comment-13915262 ] Lars Hofhansl commented on HBASE-10625: --- Oh, and times are in seconds (mean, sigma)

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915364#comment-13915364 ] Lars Hofhansl commented on HBASE-10625: --- Turns out at home I did not have block

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915396#comment-13915396 ] Lars Hofhansl commented on HBASE-10625: --- Based on the last numbers, I'll close this

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915510#comment-13915510 ] stack commented on HBASE-10625: --- bq. Was still worth a try Yes Remove unnecessary key

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915531#comment-13915531 ] Lars Hofhansl commented on HBASE-10625: --- Final numbers for reference. (Doubled

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914142#comment-13914142 ] Hadoop QA commented on HBASE-10625: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10625) Remove unnecessary key compare from AbstractScannerV2.reseekTo

2014-02-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914156#comment-13914156 ] Lars Hofhansl commented on HBASE-10625: --- The Findbugs warnings seem wrong, there