[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162736#comment-16162736 ] ramkrishna.s.vasudevan commented on HBASE-10944: bq.We have to undeprecate also. I expected this. Ok will open a new JIRa. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-10944_master.patch > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162695#comment-16162695 ] Anoop Sam John commented on HBASE-10944: This issue speak abt remove refs to kv.getBuffer() and getRow().. No dont have getRow() any more in KV. What we are doing is not removing getBuffer().. So better close this issue and open a new sub task or so? We have to undeprecate also. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-10944_master.patch > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162619#comment-16162619 ] ramkrishna.s.vasudevan commented on HBASE-10944: Will attach a patch and do it. I think hbase-2 is enough. We can remove hbase-1.5? > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161867#comment-16161867 ] stack commented on HBASE-10944: --- [~ram_krish] Ok then. Do you want to do the honors resolving? The removal of kv.getBuffer is only in hbase-2 or is it in hbase-1.5 too? (The fix version says 1.5 and hbase-2). Want to resolve the parent issue too? > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160811#comment-16160811 ] ramkrishna.s.vasudevan commented on HBASE-10944: bq.Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual code. Sorry. I meant that we will expose it for KVs and for the KV#getBuffer() add a clear comment saying that we only work with Cells. bq.Can we resolve this and the parent? Is that presumptious? Or we waiting on the MR change to complete? We can close this now. Both PrefixTree and RowIndexCodecV1 use this only for test cases. So we are good now to close this. MR can be done seperately because as I said there is no reference to KV.getBuffer() so probably not directly referring to what this JIRA does. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160770#comment-16160770
]
Anoop Sam John commented on HBASE-10944:
I read RowIndexCodecV1 and it is doing this in #decodeKeyValues.
First of all this method is not used in real code execution path. Just tests
use this. (We should mark/comment same in the Codec#Decoder itself). Also
there we do
{code}
KeyValue currentCell = KeyValueUtil.copyToNewKeyValue(cell);
out.write(currentCell.getBuffer(), currentCell.getOffset(),
currentCell.getLength());
{code}
So the cell data is been copied and made into a KV and on that calling
getBuffer. This is perfectly ok. That is what we were discussing that on the
KV the getBuffer() make sense and this should not be a deprecated method.We
dont have such methods in Cells. So things are fine as we are working with
Cells in the actual read/write flows. We can remove this deprecation with fat
comments in code as part of some of the sub task jiras here.
bq.Am fine with expsosing it for Cells. Add a clear comment saying avoid using
in the actual code.
Got confused as u refer Cell. So in Cells there wont be such methods.. This
is abt exposing it in KV where we know, we have a single buffer backing the
entire cell data. I believe u mean that only.
> Remove all kv.getBuffer() and kv.getRow() references existing in the code
> -
>
> Key: HBASE-10944
> URL: https://issues.apache.org/jira/browse/HBASE-10944
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-alpha-3
>
>
> kv.getRow() and kv.getBuffers() are still used in places to form key byte[]
> and row byte[]. Removing all such instances including testcases will make
> the usage of Cell complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160764#comment-16160764 ] stack commented on HBASE-10944: --- bq. Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual code. To what does this refer [~ram_krish]? bq, I just did a final search of kv.getBuffer - we have references to it in PrefixTreeCoder and in RowIndexCodecV1. Or just not bother w/ this holdouts? Add a comment that they need to be converted but will do later if they become relevant again (I presume RowIndexCodecV1 has been subsummed by V2? And prefixTreeCoder is a project that didn't take -- though it should have And it presumes knowledge of KV internals). Can we resolve this and the parent? Is that presumptious? Or we waiting on the MR change to complete? Thanks lads. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160734#comment-16160734 ] Anoop Sam John commented on HBASE-10944: bq.I just did a final search of kv.getBuffer - we have references to it in PrefixTreeCoder and in RowIndexCodecV1.We need to change them before we expose it for tests alone. Thanks Means we have ensureKV() calls over these places??Seems we missed them.. Will you be able to raise a jira and avoid those usages there? Thanks for the search Ram ! > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160672#comment-16160672 ] ramkrishna.s.vasudevan commented on HBASE-10944: Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual code. bq. the purge of kv from mr. Should this be a 2.0 project? Should it block the resolution of this parent issue? The code was always trying to ensure the cells are KV how ever there is no usage of Kv.getBuffer(). I just did a final search of kv.getBuffer - we have references to it in PrefixTreeCoder and in RowIndexCodecV1.We need to change them before we expose it for tests alone. Thanks [~saint@gmail.com]. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159365#comment-16159365 ] stack commented on HBASE-10944: --- [~ram_krish] See above comment sir. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140735#comment-16140735 ] stack commented on HBASE-10944: --- We can resolve this now until someone proves otherwise? And then the parent too? [~ram_krish]? Thanks for starting up HBASE-18649, the purge of kv from mr. Should this be a 2.0 project? Should it block the resolution of this parent issue? We should file an issue to plumb through an alternate Cell implementation. Could even mark it beginner. We could start collecting info on what the new Cell should be like. Do we need to do the thing [~anoop.hbase] suggested above +1'd by [~chia7712]?, i.e.: " getBuffer () exposes that buffer. This is heavily used by tests. May be we should not expose it public but for test ability exposing getBuffer() may be ok." ... before we close this? This long running project is coming to an end. Sweet. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133202#comment-16133202 ] ramkrishna.s.vasudevan commented on HBASE-10944: Yes we could do that. I can give a patch early next week. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133146#comment-16133146 ] stack commented on HBASE-10944: --- Can we deprecate and put in place an alternative method? > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131800#comment-16131800 ] ramkrishna.s.vasudevan commented on HBASE-10944: bq.We should deprecate the MR usage for 2.0.0? Yes. Then we can go forward with any alternate Cell impl. Can we break MR KV usage in 2.0 only? I think it is fine to do it. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130853#comment-16130853 ] stack commented on HBASE-10944: --- We should deprecate the MR usage for 2.0.0? We should open an issue to provide an alternative Cell implementation? > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130324#comment-16130324 ] Anoop Sam John commented on HBASE-10944: Ya we no longer use KV directly in the code path. All works with Cell interface (Apart from MR module where the change would need a Public interface break). On the KV object as such getBuffer() make sense as that Cell type is backed by a single byte[]. We resolved the issue in another way around where we have removed usage of KV directly in the code base. Tests use KV and getBuffer() from that but it should be ok IMO. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129039#comment-16129039 ] stack commented on HBASE-10944: --- How to move forward here? I like the [~ram_krish] suggestion. #getBuffer is a KV method. Long as we first ensure KV before we call #getBuffer, that is fine. What about purge of KV from MR API ? We have an issue for that? When we going to try plumbing an alternate Cell implementation through hbase? This would be sweet project. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961239#comment-15961239 ] Anoop Sam John commented on HBASE-10944: bq.We have Cells, but not quite, and in important places we still assume Cells backed by a single byte[], and the we force the single byte[] all over the place. Not really Lars. We use ensureKV calls only in some MR related code base where the public exposed classes having KV based signature. So at that time did not touch there. Apart from this very few MR code base, no other place having ensureKV calls and blind expectation of KV structure. (This is in trunk I mean) > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961229#comment-15961229 ] Lars Hofhansl commented on HBASE-10944: --- How about we get rid of ensureKeyValue? Right now we're in a bad mess: We have Cells, but not quite, and in important places we still assume Cells backed by a single byte[], and the we force the single byte[] all over the place. I'll still vote for getting rid of getBuffer() there should be absolutely no requirement to have a Cell backed by a single byte[]. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960848#comment-15960848 ] Chia-Ping Tsai commented on HBASE-10944: bq. May be we should not expose it public but for test ability exposing getBuffer() may be ok. +1 > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.5.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956825#comment-15956825 ] Anoop Sam John commented on HBASE-10944: kv.getRow() is no longer there. kv.getBuffer () -> IMHO we should not even deprecate it. This is not a method in Cell.. KV is a cell impl which is backed by a single byte[] for key and value. getBuffer () exposes that buffer. This is heavily used by tests. May be we should not expose it public but for test ability exposing getBuffer() may be ok. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956801#comment-15956801 ] Chia-Ping Tsai commented on HBASE-10944: These methods should be removed when moving 2.0 forward. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > - > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] > and row byte[]. Removing all such instances including testcases will make > the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499184#comment-14499184 ] Anoop Sam John commented on HBASE-10944: Most of the calls have gone away now by different commits. HBASE-11425 will remove all from read path (am sure) Will check once again other references and avoid them. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0, 1.1.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498667#comment-14498667 ] stack commented on HBASE-10944: --- Where are we on this issue [~ram_krish] and @anoop sam john ? Would be cool to close out the parent issue. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 2.0.0, 1.1.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119332#comment-14119332 ] Anoop Sam John commented on HBASE-10944: [~ram_krish] How abt close this and raise multiple sub tasks for specific areas(?) And target avoid kv.getBuffer() 1st. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.99.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119371#comment-14119371 ] ramkrishna.s.vasudevan commented on HBASE-10944: Ya I could raise sub jiras for them in the areas that I would be looking at. This had the intention of targetting KeyValue.ensureKV also. But I think as a new JIRA was raised will add to it. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.99.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117386#comment-14117386 ] Anoop Sam John commented on HBASE-10944: Removing all in one short will be too much of work. I came across need for removing some ref to kv.getBuffer() when doing HBASE-11872. That is from HFileWriter and diff DBE impls. I will raise a new subtask for that and attach the patch there. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Fix For: 0.99.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
[ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996070#comment-13996070 ] ramkrishna.s.vasudevan commented on HBASE-10944: The thing here to be noted is in the write path the need for key is very important. So we could try passing the Cell and create KeyOnlyKeyValue from that and use the Cell apis to create the keys. Need to see if there is any performance impact due to that. Remove all kv.getBuffer() and kv.getRow() references existing in the code - Key: HBASE-10944 URL: https://issues.apache.org/jira/browse/HBASE-10944 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Fix For: 0.99.0 kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.2#6252)
