[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974707#comment-13974707 ] Hudson commented on HBASE-11011: FAILURE: Integrated in hbase-0.96-hadoop2 #269 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/269/]) HBASE-11011 Avoid extra getFileStatus() calls on Region startup (mbertozzi: rev 1588520) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974542#comment-13974542 ] Hudson commented on HBASE-11011: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #267 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/267/]) HBASE-11011 Avoid extra getFileStatus() calls on Region startup (mbertozzi: rev 1588518) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974534#comment-13974534 ] Hudson commented on HBASE-11011: FAILURE: Integrated in HBase-TRUNK #5097 (See [https://builds.apache.org/job/HBase-TRUNK/5097/]) HBASE-11011 Avoid extra getFileStatus() calls on Region startup (mbertozzi: rev 1588517) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974509#comment-13974509 ] Hudson commented on HBASE-11011: SUCCESS: Integrated in hbase-0.96 #390 (See [https://builds.apache.org/job/hbase-0.96/390/]) HBASE-11011 Avoid extra getFileStatus() calls on Region startup (mbertozzi: rev 1588520) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974482#comment-13974482 ] Hudson commented on HBASE-11011: SUCCESS: Integrated in HBase-0.98 #283 (See [https://builds.apache.org/job/HBase-0.98/283/]) HBASE-11011 Avoid extra getFileStatus() calls on Region startup (mbertozzi: rev 1588518) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973574#comment-13973574
]
Hadoop QA commented on HBASE-11011:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640712/HBASE-11011-v2.patch
against trunk revision .
ATTACHMENT ID: 12640712
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9322//console
This message is automatically generated.
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch,
> HBASE-11011-v2.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973470#comment-13973470 ] Jean-Daniel Cryans commented on HBASE-11011: Alright, +1 > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch, > HBASE-11011-v2.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973466#comment-13973466
]
Matteo Bertozzi commented on HBASE-11011:
-
{quote}Does the changed code in completeCompactionMarker require a unit test?
Or is there already one?{quote}
none of the above, the removed code was doing nothing (see the comment inside
the function).
The output files in the entry are simply not useful
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch,
> HBASE-11011-v2.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973419#comment-13973419
]
Jean-Daniel Cryans commented on HBASE-11011:
Does the changed code in completeCompactionMarker require a unit test? Or is
there already one?
Also fix those lines:
{quote}
+// If we scan the directory and the file is not present, may means:
+// so, we can't do anything with the "compaction output list" since or is
+// already loaded on startup, because in the store folder, or it may be not
{quote}
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973196#comment-13973196 ] Jean-Daniel Cryans commented on HBASE-11011: bq. In this case is not bad, is an "expected" situation, where the RS died before moving the compacted file. This might be, but the log message doesn't convey any of that. Taken out of context (so most users reading our logs), it just says a file is missing. bq. since is trying to lookup files in /table/region/family/ and if they are there are already loaded for sure. I'm trusting you on this one :) > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973186#comment-13973186
]
Matteo Bertozzi commented on HBASE-11011:
-
{quote}The fact that a file is missing seems pretty bad, yet it's at
DEBUG.{quote}
In this case is not bad, is an "expected" situation, where the RS died before
moving the compacted file.
Anyway, I think that all the "for(compactionOutputs)" loop can be removed,
since is trying to lookup files in /table/region/family/ and if they are there
are already loaded for sure.
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973168#comment-13973168
]
Jean-Daniel Cryans commented on HBASE-11011:
What should one do when seeing this message?
{code}
+ LOG.debug("compaction file missing: " + outputPath);
{code}
The fact that a file is missing seems pretty bad, yet it's at DEBUG.
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[
https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972284#comment-13972284
]
Hadoop QA commented on HBASE-11011:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640577/HBASE-11011-v0.patch
against trunk revision .
ATTACHMENT ID: 12640577
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9311//console
This message is automatically generated.
> Avoid extra getFileStatus() calls on Region startup
> ---
>
> Key: HBASE-11011
> URL: https://issues.apache.org/jira/browse/HBASE-11011
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.2, 0.98.1, 1.0.0
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Minor
> Fix For: 1.0.0, 0.98.2, 0.96.3
>
> Attachments: HBASE-11011-v0.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a
> fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
[ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972280#comment-13972280 ] stack commented on HBASE-11011: --- lgtm [~mbertozzi] > Avoid extra getFileStatus() calls on Region startup > --- > > Key: HBASE-11011 > URL: https://issues.apache.org/jira/browse/HBASE-11011 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.2, 0.98.1, 1.0.0 >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Fix For: 1.0.0, 0.98.2, 0.96.3 > > Attachments: HBASE-11011-v0.patch > > > On load we already have a StoreFileInfo and we create it from the path, > this will result in an extra fs.getFileStatus() call. > In completeCompactionMarker() we do a fs.exists() and later a > fs.getFileStatus() > to create the StoreFileInfo, we can avoid the exists. -- This message was sent by Atlassian JIRA (v6.2#6252)
