[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096783#comment-14096783 ] Hudson commented on HBASE-11438: FAILURE: Integrated in HBase-0.98 #448 (See [https://builds.apache.org/job/HBase-0.98/448/]) HBASE-11438 - [Visibility Controller] Support UTF8 character as Visibility (ramkrishna: rev 47d1f137a2f3024836e585eaeb88ccde1db5c1b0) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsValidator.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestExpressionParser.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096877#comment-14096877 ] Hudson commented on HBASE-11438: FAILURE: Integrated in HBase-TRUNK #5397 (See [https://builds.apache.org/job/HBase-TRUNK/5397/]) HBASE-11438 - [Visibility Controller] Support UTF8 character as Visibility (ramkrishna: rev c1660a7962f9712881d2ee46d57cf781f6e1f36e) * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsValidator.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestExpressionParser.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096954#comment-14096954 ] Hudson commented on HBASE-11438: FAILURE: Integrated in HBase-1.0 #101 (See [https://builds.apache.org/job/HBase-1.0/101/]) HBASE-11438 - [Visibility Controller] Support UTF8 character as Visibility (ramkrishna: rev ae2a944027bc146efd20e3fe3498e4c717b7baed) * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestExpressionParser.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsValidator.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097028#comment-14097028 ] Hudson commented on HBASE-11438: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #422 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/422/]) HBASE-11438 - [Visibility Controller] Support UTF8 character as Visibility (ramkrishna: rev 47d1f137a2f3024836e585eaeb88ccde1db5c1b0) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestExpressionParser.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/CellVisibility.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsValidator.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097057#comment-14097057 ] Anoop Sam John commented on HBASE-11438: Same test case failures I am also getting locally. Investigating... [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097069#comment-14097069 ] ramkrishna.s.vasudevan commented on HBASE-11438: Just saw the failures. Will update the patch with an addendum.the way did not report any failure. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097132#comment-14097132
]
ramkrishna.s.vasudevan commented on HBASE-11438:
I saw this iink
{code}
https://builds.apache.org/job/HBase-TRUNK/5397/testReport/
{code}
and thought no failures in the visibility. But on seeing the link it has not
run other visibility tests.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 1.0.0, 2.0.0, 0.98.6
Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch,
HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch,
HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch,
HBASE-11438_v8.patch, HBASE-11438_v9.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097148#comment-14097148 ] Anoop Sam John commented on HBASE-11438: You can see failures in 0.98 branch test run [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097226#comment-14097226
]
ramkrishna.s.vasudevan commented on HBASE-11438:
{code}
[INFO] HBase . SUCCESS [1.482s]
[INFO] HBase - Common SUCCESS [3.460s]
[INFO] HBase - Protocol .. SUCCESS [0.086s]
[INFO] HBase - Client SUCCESS [0.692s]
[INFO] HBase - Hadoop Compatibility .. SUCCESS [0.077s]
[INFO] HBase - Hadoop Two Compatibility .. SUCCESS [0.599s]
[INFO] HBase - Prefix Tree ... SUCCESS [0.310s]
[INFO] HBase - Server SUCCESS [36.417s]
[INFO] HBase - Testing Util .. SUCCESS [0.754s]
[INFO] HBase - Thrift SUCCESS [0.696s]
[INFO] HBase - Shell . SUCCESS [0.386s]
[INFO] HBase - Integration Tests . SUCCESS [0.365s]
[INFO] HBase - Examples .. SUCCESS [0.348s]
[INFO] HBase - Assembly .. SUCCESS [0.638s]
{code}
In 0.98 the test case passes even when i ran in my linux box and in my eclipse
also. Not able to reproduce the 0.98 test failure.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 1.0.0, 2.0.0, 0.98.6
Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch,
HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch,
HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch,
HBASE-11438_v8.patch, HBASE-11438_v9.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097235#comment-14097235 ] Andrew Purtell commented on HBASE-11438: No local test failures here. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097310#comment-14097310
]
ramkrishna.s.vasudevan commented on HBASE-11438:
In Anoop's machine it failed. Seems that URF-8 is not enabled by default.
{code}
new String(array).trim();
{code}
has caused this issue where UTF-8 is not supported. Thanks to Anoop as he was
able to get this error in his machine. Anoop would provide the addendum for it.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 1.0.0, 2.0.0, 0.98.6
Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch,
HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch,
HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch,
HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097316#comment-14097316 ] Andrew Purtell commented on HBASE-11438: +1 on addendum [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097344#comment-14097344 ] Sean Busbey commented on HBASE-11438: - +1 addendum LGTM [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097527#comment-14097527 ] Hudson commented on HBASE-11438: ABORTED: Integrated in HBase-0.98 #450 (See [https://builds.apache.org/job/HBase-0.98/450/]) Amend HBASE-11438 [Visibility Controller] Support UTF8 character as Visibility Labels; Fix failing tests (apurtell: rev 3d292e8d7a7fc67d0ce492a726e4cc051c8508d6) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097528#comment-14097528 ] Hudson commented on HBASE-11438: ABORTED: Integrated in HBase-TRUNK #5399 (See [https://builds.apache.org/job/HBase-TRUNK/5399/]) Amend HBASE-11438 [Visibility Controller] Support UTF8 character as Visibility Labels; Fix failing tests (apurtell: rev 819b06d62145cdcda0a755497a1bedff0e68a450) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097796#comment-14097796 ] Hudson commented on HBASE-11438: FAILURE: Integrated in HBase-1.0 #103 (See [https://builds.apache.org/job/HBase-1.0/103/]) Amend HBASE-11438 [Visibility Controller] Support UTF8 character as Visibility Labels; Fix failing tests (apurtell: rev a79e5ce5250d76a367ca00c88a42d70530ad5f6b) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097954#comment-14097954 ] Hudson commented on HBASE-11438: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #424 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/424/]) Amend HBASE-11438 [Visibility Controller] Support UTF8 character as Visibility Labels; Fix failing tests (apurtell: rev 3d292e8d7a7fc67d0ce492a726e4cc051c8508d6) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ExpressionParser.java [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 1.0.0, 2.0.0, 0.98.6 Attachments: HBASE-11438_addendum.patch, HBASE-11438_v1.patch, HBASE-11438_v10.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095421#comment-14095421 ] ramkrishna.s.vasudevan commented on HBASE-11438: Need +1s before commit :). I am +1 for remvoing HBASE-10883. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095724#comment-14095724 ] Andrew Purtell commented on HBASE-11438: bq. What I was thinking is when a label contains these special op characters, user has to quote it. Is it that you'd like us to have the same rules of construction for visibility expressions and authorizations? For simplifying things for the user? [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095785#comment-14095785 ] Anoop Sam John commented on HBASE-11438: Yes. I am ok with the current way in patch Ram. (If you both think it is fine not to have any validation for Auth labels). Ram said, this is inline with how Accumulo also handles. If so +1 [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095804#comment-14095804
]
Andrew Purtell commented on HBASE-11438:
{quote}
Is it that you'd like us to have the same rules of construction for visibility
expressions and authorizations? For simplifying things for the user?
bq. Yes
{quote}
That's reasonable, but in authorizations what would we be escaping the quoted
chars to? We don't have operators in authorizations. Agree this does deserve
some documentation attention.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.6
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch,
HBASE-11438_v9.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095826#comment-14095826 ] Anoop Sam John commented on HBASE-11438: Like when we have 2 labels, CONFIDENTIAL and PRIVATE when we look for cells with both labels(CONFIDENTIAL PRIVATE) we have the Authorizations as new Authorizations(CONFIDENTIAL , PRIVATE); But when this is like one label only CONFIDENTIALPRIVATE and we look for cells with this status we (may) have like new Authorizations(\CONFIDENTIALPRIVATE\); In the 1st case, if user by mistake makes the incorrect way of passing the auth labels, we validate and fail fast. Yes it is ok that we better document the way to pass the auth labels during reads. (and not going with validation and so no need for quote) [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095897#comment-14095897 ] ramkrishna.s.vasudevan commented on HBASE-11438: +1 on documenting the way we should use Authorizations, the way labels are specified and using quotes on Cell Visibility. bq.new Authorizations(\CONFIDENTIALPRIVATE\); In this example what I would think is we it is just simple for the user to say (CONFIDENTIALPRIVATE). May be those escape sequences are themselves not needed. Its bit tricky if we don;t have proper documentation. If we try to add this behaviour to Authorization in the future seeing what issue users are facing in a future JIRA, is that the right way to approach this? Not only in authorizations we need to do this but also in addLabels. Ensure that before doing addLabels we need to strip the double quotes and the escape character that we add. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095127#comment-14095127 ] ramkrishna.s.vasudevan commented on HBASE-11438: [~anoop.hbase] So can we commit this ?What do you think now? [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095172#comment-14095172 ] Anoop Sam John commented on HBASE-11438: bq.Only when parsing visibility expressions will we need to differentiate between the characters that make up a label identifier and operators in the expression. There we require operator-like chars in the identifier to be quoted Yes there to differentiate, we will quote it. What I was thinking is when a label contains these special op characters, user has to quote it. Not just in CellVisibility but also in Authorizations. If the auth label is quoted we do NO validation. But when it is not, we can validate the presence of special op chars. And so HBASE-10883 still present. This was in my mind though not so strong about. If you both feel that is not really needed I will also go with you. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093034#comment-14093034 ] Andrew Purtell commented on HBASE-11438: HBASE-10883 doesn't apply if we are allowing any UTF-8 string as an authorization. There is no invalid characters to protect against, any character in an authorization will be valid, if such an authorization/label has been defined. Only when parsing visibility expressions will we need to differentiate between the characters that make up a label identifier and operators in the expression. There we require operator-like chars in the identifier to be quoted. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093736#comment-14093736 ] ramkrishna.s.vasudevan commented on HBASE-11438: Thanks [~apurtell]. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092026#comment-14092026 ] Anoop Sam John commented on HBASE-11438: IMO we should continue to have validation and should not drop HBASE-10883 fix. Ping [~apurtell]. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch, HBASE-11438_v9.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092016#comment-14092016
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12660839/HBASE-11438_v8.patch
against trunk revision .
ATTACHMENT ID: 12660839
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10369//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.6
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092021#comment-14092021
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12660840/HBASE-11438_v9.patch
against trunk revision .
ATTACHMENT ID: 12660840
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10370//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.6
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch, HBASE-11438_v7.patch, HBASE-11438_v8.patch,
HBASE-11438_v9.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087558#comment-14087558 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.But we should validate (like we did in past) Then the validation should check for double quotes and allow that. But I don't feel that would be needed. Because then we should actually parse the string rewrite the string without quotes. Same applies with authorizations also. Other argument I would suggest is that if we are allowing everything in the addLabels and authorizations what is there to be validated? And the point to see here is that in the addlabels and authorizations there is no expression that we are trying to build. So for using ,!,| should be made simple IMO. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087576#comment-14087576 ] Anoop Sam John commented on HBASE-11438: So you plan to undo HBASE-10883 fix? [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087831#comment-14087831 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.So you plan to undo HBASE-10883 fix? Yes but not fully because the validation is still getting used in checking if the visibility expression without quotes has valid characters as specified in the VisibilityLabelsValidator. If you see the description of HBASE-10883 it is mainly to disallow usage of ,!,| type of characters so that users should not use them. So by removing that check we are ensuring that user can use them now. But in authorizations there are no expressions and only string literals. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087157#comment-14087157 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.While using it in Authorizations and addLabels the user can simply specify the special characters as a normal String. Like 'aB'. But when the same has to be use in cell visibility it has to be quoted so that the system can differentiate between '' use in the label and '' used as an operator in an expression. As stated above in the comment we don't need to do any quote() while adding labels and while using it in authorizations. Because if we do that then the addLabel logic has to have a parsing logic and that should create a string without the quote that was added additionally. So we just allow the user to specify any such Strings as a normal java String. But when we use in Cell Visibility we would ensure that the user uses quotes for special characters and for characters like '','!', etc so that while parsing the expression we would be knowing that there is a usage of special characters. So while parsing this cell visibility expression if there is an occurence of any special character we just fail it. Hence the Authorizations does not have any validation because we just allow any string to be specified there. Similar is the case with addLabels. Regarding the usage of list of bytes and converting it into String, I think it is needed because we have to recreate the string without double quotes that was additionally added while doing quote(). Let me check that once again. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087167#comment-14087167 ] Anoop Sam John commented on HBASE-11438: That means we wont be having any validation for lables, while addLable() and those in Authorizations? I don't see this this the latest patch.! [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087247#comment-14087247 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.That means we wont be having any validation for lables, while addLable() and those in Authorizations? Yes we won't have. Because we are going to allow any character as the label or in authorization. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087250#comment-14087250 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.Missing a test case where addLabel and then the Mutation write with labels having special boolean operators with a label itself. - Single label A (B | C) testSimpleVisibilityLabelsWithUniCodeCharacters, testAuthorizationsWithSpecialUnicodeCharacters it does addLabels and uses the same in mutations and in authorizations. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087265#comment-14087265 ] Anoop Sam John commented on HBASE-11438: bq.Yes we won't have. IMO that won't be good. We should allow any UTF-8 chars in labels. But we should validate (like we did in past) labels in addLabels() and those in Authorizations. When user dealing with special labels which contain special boolean ops itself it it, let them quote it. Yes if quote is there we should remove this. But will it's usage be so common? For labels in AUthorizations we added validation later for better usability. So we should not drop that IMO. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.6 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082922#comment-14082922 ] ramkrishna.s.vasudevan commented on HBASE-11438: Looks unrelated test cases failing. [~anoop.hbase] Wanna have a look at this before I commit? [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083274#comment-14083274 ] Anoop Sam John commented on HBASE-11438: Sure. Started reading the patch. Will report back comments, if any, by today [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083297#comment-14083297
]
Anoop Sam John commented on HBASE-11438:
{quote}
Use this if any of the unicode characters are to be used
+ * as visibility expressions and characters like '','\','','|','!' etc
{quote}
Use this if unicode characters to be used in expression or special characters
like '(', ')', '','\','','|','!'.
Same update at quote(byte[] auth) also.
Visibility label validation logic has to include the logic of skipping the
valid char check when the chars are enclosed wih quotes (?) Do we use this
validation for labels during addLabel() , during Mutation writes and for labels
in Authorizations?
Missing a test case where addLabel and then the Mutation write with labels
having special boolean operators with a label itself. - Single label A
(B | C)
{code}
+case DOUBLE_QUOTES:
+ int labelOffset = ++index;
+ // We have to rewrite the expression within double quotes as incase
of expressions
+ // with escape characters we may have to avoid them as the original
expression did
+ // not have them
+ ListByte list = new ArrayListByte();
+ while (index endPos !endDoubleQuotesFound(exp[index])) {
+if (exp[index] == '\\') {
+ index++;
+ if (exp[index] != '\\' exp[index] != '')
+throw new ParseException(invalid escaping with quotes +
expS + at column :
++ index);
+}
+list.add(exp[index]);
+index++;
}
{code}
Why to have a List of Bytes and then do array convert and then String creation?
Instead just track the begin and end offset and finally create the String
using this 2 offset.
{code}
-if (VisibilityLabelsValidator.isValidLabel(label)) {
- if (this.visibilityManager.getLabelOrdinal(labelStr) 0) {
-RegionActionResult.Builder failureResultBuilder =
RegionActionResult.newBuilder();
-failureResultBuilder.setException(ResponseConverter
-.buildException(new LabelAlreadyExistsException(Label ' +
labelStr
-+ ' already exists)));
-response.addResult(failureResultBuilder.build());
- } else {
-Put p = new Put(Bytes.toBytes(ordinalCounter));
-p.addImmutable(
-LABELS_TABLE_FAMILY, LABEL_QUALIFIER, label,
LABELS_TABLE_TAGS);
-if (LOG.isDebugEnabled()) {
- LOG.debug(Adding the label +labelStr);
-}
-puts.add(p);
-ordinalCounter++;
-response.addResult(successResult);
- }
-} else {
+if (this.visibilityManager.getLabelOrdinal(labelStr) 0) {
RegionActionResult.Builder failureResultBuilder =
RegionActionResult.newBuilder();
failureResultBuilder.setException(ResponseConverter
- .buildException(new InvalidLabelException(Invalid visibility
label ' + labelStr
- + ')));
+ .buildException(new LabelAlreadyExistsException(Label ' +
labelStr
+ + ' already exists)));
response.addResult(failureResultBuilder.build());
{code}
Where else do we do this validation then?
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch, HBASE-11438_v7.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080620#comment-14080620
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658850/HBASE-11438_v6.patch
against trunk revision .
ATTACHMENT ID: 12658850
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.master.TestRestartCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10240//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081391#comment-14081391
]
Andrew Purtell commented on HBASE-11438:
This is what I'm talking about:
{code}
diff --git
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java
index 97c5f0f..93ab89f 100644
--- a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java
+++ b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java
@@ -114,56 +114,21 @@ public class TestScan {
@Test
public void testSetAuthorizations() {
Scan scan = new Scan();
-scan.setAuthorizations(new Authorizations(A, B, 0123, A0, 1A1,
_a));
try {
+ scan.setAuthorizations(new Authorizations(五|四));
{code}
Please don't embed unicode characters in source files.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081402#comment-14081402 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.Please don't embed unicode characters in source files. Yes Andy actually I have changed in places where there is actual comparison happening. May be i will change in all other places if needed. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081413#comment-14081413 ] Andrew Purtell commented on HBASE-11438: bq. May be i will change in all other places if needed. You should because I'll need to veto patches with embedded unicode chars. It's not good practice. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081752#comment-14081752 ] Andrew Purtell commented on HBASE-11438: bq. Removes all the unicode strings. +1 [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch, HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch, HBASE-11438_v6.patch, HBASE-11438_v7.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081759#comment-14081759
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12659011/HBASE-11438_v7.patch
against trunk revision .
ATTACHMENT ID: 12659011
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10250//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch, HBASE-11438_v5.patch,
HBASE-11438_v6.patch, HBASE-11438_v7.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075398#comment-14075398
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12657993/HBASE-11438_v4.patch
against trunk revision .
ATTACHMENT ID: 12657993
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestExpressionParser
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10195//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch, HBASE-11438_v4.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074114#comment-14074114 ] ramkrishna.s.vasudevan commented on HBASE-11438: bq.can we use unicode escapes? Am not sure on the question here? We could use unicode escape character also. See the test case added in TestVisibilityLabels. It tries to add unicode characters with unicode escape character. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074354#comment-14074354
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12657821/HBASE-11438_v3.patch
against trunk revision .
ATTACHMENT ID: 12657821
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestExpressionParser
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10188//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074914#comment-14074914
]
Andrew Purtell commented on HBASE-11438:
{quote}
bq.can we use unicode escapes?
Am not sure on the question here? We could use unicode escape character also.
See the test case added in TestVisibilityLabels. It tries to add unicode
characters with unicode escape character.
{quote}
Don't embed unicode characters in source files directly.
Use unicode escape sequences in the string constants instead to achieve the
same effect.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch,
HBASE-11438_v3.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[
https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071464#comment-14071464
]
Hadoop QA commented on HBASE-11438:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12657293/HBASE-11438_v1.patch
against trunk revision .
ATTACHMENT ID: 12657293
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+throw new ParseException(invalid escaping with quotes +
expS + at column : + index);
+ExpressionNode node = parser.parse(CellVisibility.quote(���) + +
CellVisibility.quote(���)
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestExpressionParser
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10157//console
This message is automatically generated.
[Visibility Controller] Support UTF8 character as Visibility Labels
---
Key: HBASE-11438
URL: https://issues.apache.org/jira/browse/HBASE-11438
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.98.4
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.5
Attachments: HBASE-11438_v1.patch
This would be an action item that we would be addressing so that the
visibility labels could have UTF8 characters in them. Also allow the user to
use a client supplied API that allows to specify the visibility labels inside
double quotes such that UTF8 characters and cases like , |, ! and double
quotes itself could be specified with proper escape sequence. Accumulo too
provides one such API in the client side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072369#comment-14072369 ] Andrew Purtell commented on HBASE-11438: Skimmed the v2 patch, changes look ok. Instead of embedding unicode chars into string literals, can we use unicode escapes? [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072377#comment-14072377 ] Andrew Purtell commented on HBASE-11438: bq. would require him to use CellVisibillity.quote() so that these special characters are properly quoted Requiring the user to quote reserved symbols is fine IMO. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 Attachments: HBASE-11438_v1.patch, HBASE-11438_v2.patch This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. Also allow the user to use a client supplied API that allows to specify the visibility labels inside double quotes such that UTF8 characters and cases like , |, ! and double quotes itself could be specified with proper escape sequence. Accumulo too provides one such API in the client side. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058478#comment-14058478 ] Anoop Sam John commented on HBASE-11438: bq.Should we allow '','!','|' to be used as visibility expression. You mean to be used in visibility labels? Yes we should allow IMO bq.Then we may have to provide a quote() api like Accumulo provides which the user can use to quote strings with these characters so that they can be used in the vis expressions. Yes better to give this helper API. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059026#comment-14059026 ] Andrew Purtell commented on HBASE-11438: Agree with Anoop [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11438) [Visibility Controller] Support UTF8 character as Visibility Labels
[ https://issues.apache.org/jira/browse/HBASE-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058340#comment-14058340 ] ramkrishna.s.vasudevan commented on HBASE-11438: An internal patch for this is ready. Should we allow '','!','|' to be used as visibility expression. Then we may have to provide a quote() api like Accumulo provides which the user can use to quote strings with these characters so that they can be used in the vis expressions. The corresponding parser code should handle it any way if quotes are found. [Visibility Controller] Support UTF8 character as Visibility Labels --- Key: HBASE-11438 URL: https://issues.apache.org/jira/browse/HBASE-11438 Project: HBase Issue Type: Improvement Affects Versions: 0.98.4 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.98.5 This would be an action item that we would be addressing so that the visibility labels could have UTF8 characters in them. -- This message was sent by Atlassian JIRA (v6.2#6252)
