[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176922#comment-14176922 ] Ted Yu commented on HBASE-12278: @Dima: Considering your contribution toward stabilizing tests which involve table creation race condition, you should get credit for this issue. Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177086#comment-14177086 ] Hudson commented on HBASE-12278: FAILURE: Integrated in HBase-1.0 #329 (See [https://builds.apache.org/job/HBase-1.0/329/]) HBASE-12278 Race condition in TestSecureLoadIncrementalHFilesSplitRecovery (Dima Spivak) (stack: rev 4485ba1eaea95bfa69930d8d30ef80bf8b5efda9) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Critical Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177117#comment-14177117 ] Hudson commented on HBASE-12278: FAILURE: Integrated in HBase-0.98 #613 (See [https://builds.apache.org/job/HBase-0.98/613/]) HBASE-12278 Race condition in TestSecureLoadIncrementalHFilesSplitRecovery (Dima Spivak) (stack: rev 5f91ee019535dc9a66716f16cd9aa892fc75397e) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Critical Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177135#comment-14177135 ] Hudson commented on HBASE-12278: SUCCESS: Integrated in HBase-TRUNK #5675 (See [https://builds.apache.org/job/HBase-TRUNK/5675/]) HBASE-12278 Race condition in TestSecureLoadIncrementalHFilesSplitRecovery (Dima Spivak) (stack: rev 0ee33094ed202cad16bc8a1724eafce7c7cd48c6) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Critical Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177175#comment-14177175 ] Hudson commented on HBASE-12278: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #583 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/583/]) HBASE-12278 Race condition in TestSecureLoadIncrementalHFilesSplitRecovery (Dima Spivak) (stack: rev 5f91ee019535dc9a66716f16cd9aa892fc75397e) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Critical Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176398#comment-14176398 ] Dima Spivak commented on HBASE-12278: - Can't we all just get along? :) My two cents, since I'm sorry to say that my day's delay in posting a patch apparently caused this conflict: I'm totally fine with someone solving a problem that I noticed but didn't fix (just a week back, Stack fixed HBASE-12212 for me because I wasn't familiar with what needed to be done). That said, I can understand frustration when an established member of the community jumps in on an issue that a new contributor has put effort toward solving; it definitely has the potential to chill contributions. Personally, I'm less concerned about getting credit for a patch than about having my test rig stable, but if I were just starting out on this project, I could see what happened here as evidence that HBase developers compete to get patches up first instead of cooperating. This all goes out the door, of course, if someone had filed an unassigned critical blocker that I assigned myself to before taking my sweet time to fix, but [~yuzhih...@gmail.com], you yourself made a point for me to re-prioritize a nearly-identical fix (HBASE-12229) as minor, so I was frankly a little taken aback by how important you thought it was to get this patch up before I had the chance to. Lost in all of this is that TestSecureLoadIncrementalHFilesSplitRecovery (jeez, what a mouthful) still has a race condition. Can someone please push the fix so that we can have a big group hug and go fix other flakey tests? :) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176094#comment-14176094 ] stack commented on HBASE-12278: --- [~ted_yu] Go work on your own issues instead of hijacking those of others. Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Ted Yu Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176099#comment-14176099 ] Ted Yu commented on HBASE-12278: The above comment wasn't unexpected. Dima didn't attach any patch. My patch got +1 from Dima. I hope there is nurturing for cooperative atmosphere in this open source project. Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Ted Yu Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176149#comment-14176149 ] stack commented on HBASE-12278: --- bq. I hope there is nurturing for cooperative atmosphere in this open source project. There is usually. Take a look around. You are being called out for being the opposite of 'nurturing' and 'cooperative' with your obnoxious hijacking. bq. Dima didn't attach any patch. He filed the issue. He assigned it himself -- which usually is a flag that a fella intends working on the thing. He was trying to do a proper fix, not a hack like your v1. He was waiting on dependent issue getting committed before adding an item here Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Ted Yu Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175805#comment-14175805 ] Dima Spivak commented on HBASE-12278: - Ted, I'm actually waiting for HBASE-12229 to get committed, because that adds a HBTU#createTable method that fits this case. Wanna take a look there? Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor Attachments: 12278-v1.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175818#comment-14175818 ] stack commented on HBASE-12278: --- @dima HBASE-12229 committed. What you thinking? Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor Attachments: 12278-v1.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[ https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175836#comment-14175836 ] Dima Spivak commented on HBASE-12278: - :) Yep, that's exactly what I've been sitting on. +1 from me. Race condition in TestSecureLoadIncrementalHFilesSplitRecovery -- Key: HBASE-12278 URL: https://issues.apache.org/jira/browse/HBASE-12278 Project: HBase Issue Type: Bug Components: test Affects Versions: 1.0.0 Reporter: Dima Spivak Assignee: Dima Spivak Priority: Minor Attachments: 12278-v1.txt, 12278-v2.txt I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on me because of a TableNotFoundException. Fix is pretty simple and will involve a little bit of test refactoring to get rid of some duplicate behavior that's done better in HBaseTestingUtility anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12278) Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
[
https://issues.apache.org/jira/browse/HBASE-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175869#comment-14175869
]
Hadoop QA commented on HBASE-12278:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675648/12278-v2.txt
against trunk revision .
ATTACHMENT ID: 12675648
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11395//console
This message is automatically generated.
Race condition in TestSecureLoadIncrementalHFilesSplitRecovery
--
Key: HBASE-12278
URL: https://issues.apache.org/jira/browse/HBASE-12278
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 1.0.0
Reporter: Dima Spivak
Assignee: Dima Spivak
Priority: Minor
Attachments: 12278-v1.txt, 12278-v2.txt
I sometimes get #testGroupOrSplitWhenRegionHoleExistsInMeta to error out on
me because of a TableNotFoundException. Fix is pretty simple and will involve
a little bit of test refactoring to get rid of some duplicate behavior that's
done better in HBaseTestingUtility anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
